examples tests: fix typo and update libpipeline test
Metadata
Current evaluation
PR #325 (typo fix + libpipeline example test update) was closed unmerged by author come-maiz, who withdrew it to rewrite the tests differently. The same work landed via PR #326 (merge commit 8e2bff011, commit 8611ef560).
Resolution: closed superseded
Reason: The author closed PR #325 unmerged with the comment "wait wait wait, scratch this. I want to do this in a different way. Each test will be more verbose, but clearer", and the issue was reworked and merged as snapcraft#326 in commit 8e2bff011 ("examples_tests: fix the libpipeline test", commit 8611ef560), which also references the same Launchpad bug LP: #1546771.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | PR #325 (typo fix + libpipeline example test update) was closed unmerged by author come-maiz, who withdrew it to rewrite the tests differently. The same work landed via PR #326 (merge commit 8e2bff011, commit 8611ef560). | |
| stealth/space-bunny-alpha | — | closed superseded | PR #325 (typo fix + libpipeline test update, LP #1546771) was closed unmerged; the author withdrew it and redid the work more verbosely in merged PR #326, which split the libpipeline example tests into separate files. | |
| stealth/space-bunny-alpha | — | closed superseded | Abandoned unmerged; its test rewrite was replaced by merged PR canonical/snapcraft#326 (commit 8e2bff011), which split libpipeline example tests into clearer, independently debuggable files. | |
| qwen/qwen3.6-35b-a3b | — | — | Abandoned by the author, who requested to scratch the changes to rewrite the tests more verbosely and clearly for debugging. No modifications were merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Abandoned by author to implement a clearer, more verbose testing approach. The typo fix and libpipeline update were discarded and superseded by a different implementation. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#326
(confidence 95%)
Follow-up PR on branch examples_typo-2 for the same LP: #1546771, merged as commit 8e2bff011 with the libpipeline test fix and typo correction.
-
Likely Fixed By:
canonical/snapcraft#326
(confidence 80%)
Commit 8611ef560 'examples_tests: fix the libpipeline test.' carries the substantive test change that #325 attempted.
-
Related To:
canonical/snapcraft#341
(confidence 35%)
Later commit d64b0f5e3 further adjusted the libpipeline example test (skipping output assertion when install is skipped).
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #326 examples_tests: fix the libpipeline test. | snapcraft | merged | Merged PR #326 as commit 8611ef560, refactoring example tests into independent files and fixing the libpipeline test for LP #1546771. | |
| #1546771 typo on examples tests, no internal commands being run | snapcraft (launchpad) | closed | Fixed the examples-test typo by merging ubuntu-core/snapcraft#326 (commit 8611ef560), restoring the libpipeline test command; earlier PR #325 was closed. | |
| #387 libpipeline example test: update the binary name | snapcraft | closed | Closed unmerged in favor of rebased #389, which merged the libpipeline binary-name test update via commit 238febdf7. |