← Back to issue list

examples_tests: fix the libpipeline test.

View original Github issue

Metadata

Project
snapcraft
Number
#326
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #326 as commit 8611ef560, refactoring example tests into independent files and fixing the libpipeline test for LP #1546771.

Resolution: closed resolved

Reason: PR #326 was merged through merge commit 8e2bff011, with implementation commit 8611ef560 completing the libpipeline test fix.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Refactor the examples tests to be able to write them independently, each on its own file. LP: #1546771

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #326 as commit 8611ef560, refactoring example tests into independent files and fixing the libpipeline test for LP #1546771.
stealth/space-bunny-alpha — closed resolved Merged PR #326 in commit 8611ef560 (merge 8e2bff011), fixing LP #1546771 by splitting examples tests into independent files and correcting the libpipeline test.
stealth/space-bunny-alpha — closed resolved Merged PR #326 (commit 8611ef560) refactored libpipeline example tests into independent files, fixing the test issue tracked as LP #1546771.
qwen/qwen3.6-35b-a3b — — Merged a refactor of libpipeline example tests into independent files to fix testing failures. The changes (+347/-245 lines across 5 files) were reviewed and approved, successfully resolving the test suite issues.
qwen3.6-35b-a3b-mtp-q6 — — Merged after refactoring examples tests into independent files to fix the libpipeline test and replace large shared fixtures. Reviewers approved the modular structure despite initial size concerns.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#325 examples tests: fix typo and update libpipeline test snapcraft closed PR #325 (typo fix + libpipeline example test update) was closed unmerged by author come-maiz, who withdrew it to rewrite the tests differently. The same work landed via PR #326 (merge commit 8e2bff011, commit 8611ef560).
81%
#387 libpipeline example test: update the binary name snapcraft closed Closed unmerged in favor of rebased #389, which merged the libpipeline binary-name test update via commit 238febdf7.
75%
#389 libpipeline example test: update the binary name snapcraft merged PR #389 by sergiusens updated the libpipeline example test's expected binary name for the new ubuntu-core release, fixing rolling-edge failures (LP #1560254). Merged via commit 26715f38d (squashed as 238febdf7).
72%
#341 examples_tests/libpipeline: skip the output assertion when skipping the install snapcraft merged Merged PR #341 fixed LP #1550108 by skipping the libpipeline output assertion when installation is skipped; merge commit 509011969.
72%
#272 Fix the examples tests using testtools as the base. snapcraft merged Merged PR #272 updated the examples tests to use testtools, fixing LP #1539196 in commit 5f39d00e9 (merge 7e5a479ae).
72%
#1554641 libpipeline example needs to be reviewed snapcraft (launchpad) closed The libpipeline example test was updated by ubuntu-core/snapcraft#368, merged as f4f02c0d2, to handle the empty working directory and grep behavior.
72%
#1554637 libpipeline example fails because it is now run in an empty dir snapcraft (launchpad) closed Updated the libpipeline example test to expect empty output in the new working directory; merged in snapcraft#368 via commit 0eb3337dc.
72%