← Back to issue list

build providers: honour http proxy settings for snapd

View original Github issue

Metadata

Project
snapcraft
Number
#3251
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/snapcraft#3251 (fbd93aaab), configuring snapd with user http_proxy and https_proxy values on every build-provider launch.

Resolution: closed resolved

Reason: Pull request #3251 was approved and merged as commit fbd93aaab, applying updated proxy configuration each time snapd was launched.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Configure snapd with the proxy settings configured by the user for http_proxy and https_proxy. Do this on each launch so that any changes in configuration passed are applied. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#3251 (fbd93aaab), configuring snapd with user http_proxy and https_proxy values on every build-provider launch.
stealth/space-bunny-alpha — closed resolved Merged in #3251 (commit fbd93aaab), configuring snapd with user http_proxy and https_proxy settings on every launch so configuration changes are applied.
stealth/space-bunny-alpha — closed resolved Merged in snapcraft#3251 (fbd93aaab), applying user-defined http_proxy and https_proxy settings to snapd on every launch so configuration changes are honored.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#3251 (fbd93aaab), applying configured http_proxy and https_proxy settings to snapd on each launch.
qwen/qwen3.6-35b-a3b — — Merged after reviewer approval and passing CI checks. The update configures snapd to automatically apply user-defined http_proxy and https_proxy settings on each launch, ensuring proxy changes are respected.
qwen3.6-35b-a3b-mtp-q6 — — Merged implementation configuring snapd to apply user-defined http_proxy and https_proxy settings on each launch. Minor test breakage and edge case concerns were noted during review, but the changes were successfully integrated.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#3906 (confidence 90%)

    Later forwarded both proxy variables to craft-providers for core22 build instances.

Related issues

Issue Project State Summary Similarity
#149 buildd: set snapd http-proxy and https-proxy craft-providers merged Merged PR #149 in commit 48fe5a2, configuring snapd HTTP/HTTPS proxies from environment variables; shipped in craft-providers 1.4.2.
80%
#3343 build providers: set snapd proxy settings prior to _setup_snapcraft() snapcraft closed PR #3343 was closed unmerged after debugging was requested; the maintainer said to reopen it once the issues were fixed.
72%
#2507 build providers: improve handling in snap logic snapcraft merged Merged snapcraft#2507 as commit 841b41fa3, improving build-provider snap logic, removing unnecessary sudo calls, and silencing refresh-hold noise.
71%
#3141 build providers: use LXD-provided DNS by default snapcraft merged Merged in canonical/snapcraft#3141 via commit 0a9fe51ad, making build providers use LXD-provided DNS through systemd-resolved and restart networkd without restarting containers.
70%