← Back to issue list

build providers: improve handling in snap logic

View original Github issue

Metadata

Project
snapcraft
Number
#2507
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged snapcraft#2507 as commit 841b41fa3, improving build-provider snap logic, removing unnecessary sudo calls, and silencing refresh-hold noise.

Resolution: closed resolved

Reason: The approved pull request was merged as commit 841b41fa3, resolving LP #1820864. It cleaned up snap channel handling, removed unnecessary sudo usage, and reduced refresh-hold warnings.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Cleanup up the channel warning when the SNAPCRAFT_BUILD_ENVIRONMENT_CHANNEL_SNAPCRAFT is not set. Removed unnecessary use of sudo, given that the providers all run as root. Silenced the call on holds for refreshes as it is unnecessarily noisy and adds little value to users. LP: #1820864 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged snapcraft#2507 as commit 841b41fa3, improving build-provider snap logic, removing unnecessary sudo calls, and silencing refresh-hold noise.
stealth/space-bunny-alpha — closed resolved Merged in #2507 as commit 841b41fa3, improving snap build-provider logic, removing unnecessary sudo calls, and silencing refresh-hold noise.
qwen/qwen3.6-35b-a3b — — Merged. Improved snap provider logic by cleaning up channel warnings, removing unnecessary sudo calls, and silencing noisy refresh hold commands. Approved, passed CI, and modified 5 files (+131/-73 lines).
qwen3.6-35b-a3b-mtp-q6 — — Merged improvements to snap build provider logic. Changes clean up channel warnings, remove unnecessary sudo calls, and silence noisy refresh holds. Resolves LP #1820864.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1821586 Improved build provider sanity checks snapcraft (launchpad) closed Resolved by merged snapcraft#2515 (commit e4a578823), moving build-provider setup and sanity checks into provider implementations.
79%
#3102 build providers: prevent snap refreshing in build environment snapcraft merged Merged PR #3102 as commit 2ff9fcd10, adding a one-day refresh hold for installed snaps to prevent automatic refreshes in build environments.
77%
#1782777 Improve installation/injection logic for snapcraft (and core) snapcraft (launchpad) closed Fixed by merged snapcore/snapcraft PR #2196 in commit d9a477ea5, improving build-provider installation and snap injection logic.
76%
#2265 build providers: allow snapcraft channel selection snapcraft merged Merged build-provider Snapcraft channel selection for non-host-injected early testing, with a user warning, in commit 6a3d2d3cd (#2265).
74%
#2281 build providers: re-exec as root snapcraft merged Merged PR #2281 (commit d6ec1d24e) by sergiusens makes Snapcraft re-exec itself as root when running in managed-host build-provider environments, fixing LP #1791977 (+13 lines, 1 file, 1 approval).
73%
#3049 build providers: rename default sources snapcraft merged Merged in canonical/snapcraft#3049 as 3726b8d99, renaming reserved build-provider keys to default.sources and default-security.sources.
73%
#1779136 build provider support to clean parts snapcraft (launchpad) closed Build-provider support for cleaning selected parts was restored by merged canonical/snapcraft PR #2442 (commit 5546c3aab), without deleting the provider.
72%
#2174 build_providers: inject snaps when running from a snap snapcraft merged Merged PR #2174 (commit 283ab0bb8) to inject host Snapcraft and base snaps when running from the snapcraft snap, while non-snap runs install them from the store.
72%
#1779137 build provider support to inject snaps on the host snapcraft (launchpad) closed Build providers gained host-snap injection when Snapcraft runs from a snap; fixed by merged snapcore/snapcraft#2174 (commit 283ab0bb8).
72%
#182 bases: disable automatic snap refreshes craft-providers merged Merged PR #182 (commit 562257a, CRAFT-1518) disables automatic snap refreshes in build providers by running `snap set system refresh.hold=24h` during setup() and warmup(), fixing #174 and LP#1998100.
72%