← Back to issue list

remote-build: use requests.get() instead of urlopen()

View original Github issue

Metadata

Project
snapcraft
Number
#3255
Type
pull request
State
merged
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Replaced urlopen() with requests.get() in remote-build to standardize on the requests library. Merged following approval and passing CI, resolving SNAPCRAFT-1ZK in conjunction with PR #3252.

Suggested action:

No scores available.

Issue body

A step towards standardizing on requests library. When combined with PR #3252: Fixes SNAPCRAFT-1ZK Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Replaced urlopen() with requests.get() in remote-build to standardize on the requests library. Merged following approval and passing CI, resolving SNAPCRAFT-1ZK in conjunction with PR #3252.
qwen3.6-35b-a3b-mtp-q6 Replaced urlopen() with requests.get() in the remote-build module to standardize on the requests library. Merged to resolve SNAPCRAFT-1ZK alongside PR #3252.
qwen3.6-35b-a3b-mtp-q6 Merged to replace urlopen() with requests.get() in remote-build, standardizing HTTP calls on the requests library and resolving SNAPCRAFT-1ZK.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3076 remote-build: fix case where build log url is None snapcraft merged Merged a fix for a None build log URL in remote builds. Added logging and unit tests to resolve SNAPCRAFT-1JW and SNAPCRAFT-1FS. Approved by one reviewer, passed CI, and merged with 40 additions and 11 deletions across two files.
72%