← Back to issue list

remote-build: fix case where build log url is None

View original Github issue

Metadata

Project
snapcraft
Number
#3076
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged a fix for a None build log URL in remote builds. Added logging and unit tests to resolve SNAPCRAFT-1JW and SNAPCRAFT-1FS. Approved by one reviewer, passed CI, and merged with 40 additions and 11 deletions across two files.

Suggested action: —

No scores available.

Issue body

Log when there is no URL to be downloaded. Add unit test case coverage. Fixes: SNAPCRAFT-1JW, SNAPCRAFT-1FS Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged a fix for a None build log URL in remote builds. Added logging and unit tests to resolve SNAPCRAFT-1JW and SNAPCRAFT-1FS. Approved by one reviewer, passed CI, and merged with 40 additions and 11 deletions across two files.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix for remote-build handling None build log URLs. Added logging and unit tests to cover the edge case, resolving SNAPCRAFT-1JW and SNAPCRAFT-1FS.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix for remote-build handling a None build log URL. Added logging and unit test coverage. Resolves SNAPCRAFT-1JW and SNAPCRAFT-1FS.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#299 fix(remote-build): minor edge cases found with snapcraft craft-application merged Fixed minor snapcraft edge cases in remote builds. Merged following approval by two reviewers and passing CI checks. The update modifies three files, adding 43 lines and removing 13.
74%
#2594 remote build: don't send log files back to remote snapcraft merged Merged a fix updating build log filters to prevent local logs from being sent to the remote builder. Approved by reviewer, passed CI, and modified two files with four additions and four deletions.
74%
#4432 fix(remote-build): improve logging and catch exceptions snapcraft merged Merged pull request improving remote build logging and exception handling. Approved by reviewers, passed CI checks, and resolves issue #4399.
73%
#3648 cli: reintroduce remote-build and promote to snapcraft help snapcraft merged Merged the reintroduction of the remote-build CLI command and promoted it to snapcraft help. Approved by one reviewer, passed CI checks, and resolved Launchpad bug #1943244 via a single-file, four-line deletion.
73%
#2642 remote-build: detect early build errors snapcraft merged Merged. Improved remote build error detection to distinguish between pending builders and actual failures like missing config or timeouts. Approved by reviewer, passed CI, and modified 3 files (+131/-47 lines). Minor import fix applied.
72%
#4382 tests: use less mocks in remote-build snapcraft merged Merged changes replace mocked snapcraft.yaml loading in remote-build tests with direct file creation. Approved by two reviewers, passed CI, and serves as preparatory work for issue #4322.
72%
#3255 remote-build: use requests.get() instead of urlopen() snapcraft merged Replaced urlopen() with requests.get() in remote-build to standardize on the requests library. Merged following approval and passing CI, resolving SNAPCRAFT-1ZK in conjunction with PR #3252.
72%
#2765 remote-build: initial Windows support snapcraft merged Merged initial Windows support for remote-build. Approved by one reviewer, adding 72 lines and removing 26 across six files. Requires snapcraft PR #2759.
71%
#351 fix(remotebuild): use full project name in log files craft-application merged Merged a fix ensuring remote build log files use the full project name, resolving issue #4781. Approved by three reviewers, passed CI, and updated two files.
71%
#196 feat: remote build service craft-application merged Merged the remote build service feature, migrating code from snapcraft. Approved by two reviewers, passed CI checks, and introduced 2316 lines across 26 files.
71%