remote-build: fix case where build log url is None
Metadata
Current evaluation
Merged in snapcraft#3076 (commit 2c1dfe63c), fixing remote-build handling when the build log URL is absent and adding unit coverage.
Resolution: closed resolved
Reason: PR #3076 was merged into the project. Commit 2c1dfe63c logs when no build-log URL is available and adds regression test coverage.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Log when there is no URL to be downloaded.
Add unit test case coverage.
Fixes: SNAPCRAFT-1JW, SNAPCRAFT-1FS
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcraft#3076 (commit 2c1dfe63c), fixing remote-build handling when the build log URL is absent and adding unit coverage. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #3076 (commit 2c1dfe63c) merged: remote-build now logs instead of failing when the build log URL is None, with added unit test coverage for SNAPCRAFT-1JW/SNAPCRAFT-1FS. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3076, fixing remote-build handling when a build log URL is None by logging that no URL is available and adding unit-test coverage. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged remote-build fix to log when a build log URL is None, with unit test coverage for SNAPCRAFT-1JW and SNAPCRAFT-1FS. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix for a None build log URL in remote builds. Added logging and unit tests to resolve SNAPCRAFT-1JW and SNAPCRAFT-1FS. Approved by one reviewer, passed CI, and merged with 40 additions and 11 deletions across two files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for remote-build handling None build log URLs. Added logging and unit tests to cover the edge case, resolving SNAPCRAFT-1JW and SNAPCRAFT-1FS. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #299 fix(remote-build): minor edge cases found with snapcraft | craft-application | merged | Merged PR #299 fixed Snapcraft-related remote-build edge cases in three files, landing as commit 15087962 after two approvals. | |
| #4382 tests: use less mocks in remote-build | snapcraft | merged | PR #4382 merged (commit 906834cda): remote-build unit tests no longer mock snapcraft.yaml loading but write and load real project files, prep for #4322. | |
| #2785 remote-build: add initial command unit tests | snapcraft | merged | PR #2785 by cjp256 merged into snapcraft master, adding initial unit tests for the remote-build command covering build-on arch handling; reviewer comments were addressed and the branch rebased. | |
| #196 feat: remote build service | craft-application | merged | Merged PR #196 in commit e53de201, adding remote build service support and porting the latest remote-build implementation from Snapcraft. | |
| #351 fix(remotebuild): use full project name in log files | craft-application | merged | Merged in craft-application#351 via commit 26021675, preserving full project names in remote-build log filenames and fixing canonical/snapcraft#4781. | |
| #4478 bug: remote-build broke in snapcraft 8.0 | snapcraft | closed | Fixed by PR #4482, merged as commit 6300e0ee2: remote-build pushes now use the Git CLI instead of libgit2, avoiding SSL broken-pipe failures. | |
| #4432 fix(remote-build): improve logging and catch exceptions | snapcraft | merged | Merged #4432, adding RemoteBuildError handling and improving remote-build logging for #4399; commits fb9a01d0b and 663dcdfab. | |
| #3648 cli: reintroduce remote-build and promote to snapcraft help | snapcraft | merged | Merged PR #3648 (commit 8dc1ac016), restoring remote-build and promote in Snapcraft's main CLI help for Launchpad bug #1943244. | |
| #2774 remote-build: architecture handling | snapcraft | merged | Merged PR #2774 via commit 8300281d6, cleaning up and fixing remote-build architecture handling. Missing CLI unit tests were acknowledged as follow-up work. | |
| #1876123 remote-build failed | snapcraft (launchpad) | closed | Remote-build’s None build-log URL crash was likely fixed by merged PR #3076 (2c1dfe63c); Launchpad #1876123 was later closed as expired after 60 days without activity. |