← Back to issue list

colcon v2 plugin: don't strip environment for stage-runtime-dependencies

View original Github issue

Metadata

Project
snapcraft
Number
#3264
Type
pull request
State
closed
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Closed without merging. The author abandoned the changes after environment stripping was found to unset SNAPCRAFT_STAGE, breaking sitecustomize. Further consideration is needed to properly handle proxy variables and environment passing.

Suggested action:

No scores available.

Issue body

HTTP proxy settings are being lost. - Remove the `-i` argument to `env`, there are no longer variables that must be filtered, allow all of the build-time environment variables through. This will include http(s)_proxy once the run scripts include it (shipped separately). - Remove parameters to `stage-runtime-dependencies` which can just be picked up from the environment now, after removing `-i` from `env`. - Remove PATH from env list as it no longer needs to be passed through explicitly, it is in the run script.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Closed without merging. The author abandoned the changes after environment stripping was found to unset SNAPCRAFT_STAGE, breaking sitecustomize. Further consideration is needed to properly handle proxy variables and environment passing.
qwen3.6-35b-a3b-mtp-q6 Closed without merging. The author deferred the change after discovering that environment stripping breaks SNAPCRAFT_STAGE and sitecustomize. The fix requires further consideration to properly pass proxy variables without unintended side effects.
qwen3.6-35b-a3b-mtp-q6 Closed without merging. Removing environment stripping to preserve HTTP proxy settings conflicted with SNAPCRAFT_STAGE handling, breaking sitecustomize. The author abandoned the pull request pending further consideration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3265 colcon v2 plugin: honour http(s) proxy for stage-runtime-dependencies snapcraft merged Merged after approval and passing CI checks. The change updates the colcon v2 plugin to honor http(s) proxy settings for stage-runtime-dependencies, modifying two files with a +13/-3 line diff.
71%