← Back to issue list

colcon v2 plugin: honour http(s) proxy for stage-runtime-dependencies

View original Github issue

Metadata

Project
snapcraft
Number
#3265
Type
pull request
State
merged
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Merged after approval and passing CI checks. The change updates the colcon v2 plugin to honor http(s) proxy settings for stage-runtime-dependencies, modifying two files with a +13/-3 line diff.

Suggested action:

No scores available.

Issue body

Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval and passing CI checks. The change updates the colcon v2 plugin to honor http(s) proxy settings for stage-runtime-dependencies, modifying two files with a +13/-3 line diff.
qwen3.6-35b-a3b-mtp-q6 Merged. The colcon v2 plugin now honours http(s) proxy settings for stage-runtime-dependencies, implemented by maintainer cjp256.
qwen3.6-35b-a3b-mtp-q6 Merged. The colcon v2 plugin now honors http(s) proxy configurations when fetching stage-runtime-dependencies, ensuring correct network routing during package builds.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3263 colcon v2 plugin: honour http(s) proxy for all build commands snapcraft closed Closed without merging, the colcon v2 plugin proxy support change was abandoned after six years of inactivity, receiving zero reviews, comments, or CI checks.
83%
#3638 colcon v2: forward cmake args snapcraft merged Merged a fix ensuring colcon-cmake-args are forwarded to the build command in the Colcon v2 plugin. Approved by reviewer, passed CI, and achieved 100% diff coverage.
73%
#3264 colcon v2 plugin: don't strip environment for stage-runtime-dependencies snapcraft closed Closed without merging. The author abandoned the changes after environment stripping was found to unset SNAPCRAFT_STAGE, breaking sitecustomize. Further consideration is needed to properly handle proxy variables and environment passing.
71%
#2456 plugins: add colcon plugin snapcraft merged Merged the colcon plugin for ROS2 builds, resolving LP: #1805213. Added as a beta feature, the change was approved by two reviewers, passed CI with 100% diff coverage, and introduced 2120 lines across 16 files.
71%