meta: add suite/component validation checks for package-repositories
Metadata
Current evaluation
PR #3276 was closed unmerged after more than six years without review, CI, comments, or a recorded replacement; no resolving commit was identified.
Resolution: closed stale
Reason: Repository metadata shows the proposed validation remained unmerged with no reviewers, CI runs, comments, or closing explanation before being closed after prolonged inactivity.
Evaluated by: mr-cal-bot
No scores available.
Issue body
According to apt's sources.list manpage, there are two invalid cases
that snapcraft should verify:
(1) No components must be specified if suite is a path. Apt determines
that a suite is a path if it ends with a "/".
(2) Due to the above requirement, it follows that suite types cannot
be mixed in the same repository object.
This commit makes the following changes:
- Add these checks to package-repositories when being unmarshalled.
- Note #1 in the specification and JSON schema.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed stale | PR #3276 was closed unmerged after more than six years without review, CI, comments, or a recorded replacement; no resolving commit was identified. | |
| stealth/space-bunny-alpha | — | closed stale | Package-repository suite/component validation was proposed but never merged; PR #3276 was closed unmerged after more than six years without review or CI. | |
| stealth/space-bunny-alpha | — | closed stale | Abandoned unmerged: package-repository suite/component validation was closed after more than six years without review, CI, or a closing explanation. | |
| stealth/space-bunny-alpha | — | closed stale | Closed after 2,214 days without review or CI; no merge or superseding change is recorded for the proposed suite/component validation. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. The validation checks for package-repositories were abandoned due to lack of reviewer engagement and CI verification. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged and closed. Implemented validation checks for apt package-repositories to enforce suite and component rules during unmarshalling, updating the specification and JSON schema accordingly. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3334 package repositories: improve error handling | snapcraft | merged | PR #3334 merged as commit 71eabdc6c: added PackageRepositoriesValidationError pointing at package-repositories docs, converted validation RuntimeErrors, and added empty url/ppa/suites/components checks. |