meta: add suite/component validation checks for package-repositories
Metadata
Current evaluation
Closed without merging. The validation checks for package-repositories were abandoned due to lack of reviewer engagement and CI verification.
Suggested action: —
No scores available.
Issue body
According to apt's sources.list manpage, there are two invalid cases
that snapcraft should verify:
(1) No components must be specified if suite is a path. Apt determines
that a suite is a path if it ends with a "/".
(2) Due to the above requirement, it follows that suite types cannot
be mixed in the same repository object.
This commit makes the following changes:
- Add these checks to package-repositories when being unmarshalled.
- Note #1 in the specification and JSON schema.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. The validation checks for package-repositories were abandoned due to lack of reviewer engagement and CI verification. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged and closed. Implemented validation checks for apt package-repositories to enforce suite and component rules during unmarshalling, updating the specification and JSON schema accordingly. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without comments after implementing validation checks for package-repositories to enforce apt sources.list rules during unmarshalling. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #216 repo: add support for package repositories | rockcraft | closed | Closed without review or merge. The pull request adding package repository support received no comments, approvals, or CI checks, indicating it was likely abandoned. | |
| #3334 package repositories: improve error handling | snapcraft | merged | Improves package repository error handling by introducing PackageRepositoriesValidationError to replace generic RuntimeErrors. Adds checks for empty URLs, PPAs, suites, and components. Approved and merged after passing CI. |