build providers: rename clean() -> clean_parts() to clarify scope
Metadata
Current evaluation
Merged into master. Renames build provider clean() to clean_parts() to clarify scope, as cleanup extends beyond parts. Approved by one reviewer with 100% diff coverage and zero unresolved comments.
Suggested action: —
No scores available.
Issue body
There more aspects to cleaning than just the parts, such as
clean_project() or other build instance cleanup. To make
the method's scope more obvious, rename clean() to clean_parts().
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. Renames build provider clean() to clean_parts() to clarify scope, as cleanup extends beyond parts. Approved by one reviewer with 100% diff coverage and zero unresolved comments. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Renamed build providers clean() to clean_parts() to clarify method scope. The change maintained 100% diff coverage and was successfully integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Renamed clean() to clean_parts() in build providers to clarify scope. Merged into master after passing code coverage checks, following initial unrelated godeps failures. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2474 build providers: remove dead code | snapcraft | merged | Merged removal of dead code for legacy cleanbuild support in build providers. Approved by one reviewer, passed CI, and modified three files (+54/-165 lines). | |
| #2442 cli: enable cleaning of parts | snapcraft | merged | Merged PR restoring snapcraft clean <part-name> functionality for build providers. Reviewers noted edge cases with dependent parts and suggested future improvements for VM-level cleanup, but the feature was successfully integrated. | |
| #3434 build providers: clean environment if project directory is changed | snapcraft | merged | Merged into master. Fixes environment cleanup when project directories are relocated or reused. The build provider now tracks the directory path, verifies compatibility, and automatically cleans the environment on mismatch. Approved and passed CI. | |
| #88 fix: clean build provider when no parts are given | craft-application | merged | Merged. Refactors AppCommand.run_managed and adds ProviderService.clean_instances() to clean the build provider when no parts are provided. Routes cleanup via CLI args. Fixes #56 and increases coverage by 0.03%. | |
| #2374 build providers: destroy on create failures | snapcraft | merged | Merged. Resolves a bug where build providers and VMs remained running after launch failures. Adds cleanup logic and tests across seven files, approved by a reviewer and passing CI checks. | |
| #2282 build providers: cleaner start and launch messaging | snapcraft | merged | Merged changes that clean up start and launch messaging for build providers. Approved by one reviewer, passed CI checks, and modified eight files to address Launchpad issue #1793101. |