build providers: rename clean() -> clean_parts() to clarify scope
Metadata
Current evaluation
Merged into master as commit 81ade060c: build provider clean() renamed to clean_parts() (5 files, +9/-9) to distinguish parts cleanup from clean_project() and other build instance cleanup.
Resolution: closed resolved
Reason: PR #3284 by maintainer cjp256 was approved and squash-merged into master as commit 81ade060c ("build providers: rename clean() -> clean_parts() to clarify scope (#3284)"), confirmed present in the project's commit history. The renamed clean_parts() method was later reused by commit abcafbfab (PR #3680, 'commands, parts: add clean command').
Evaluated by: mr-cal-bot
No scores available.
Issue body
There more aspects to cleaning than just the parts, such as
clean_project() or other build instance cleanup. To make
the method's scope more obvious, rename clean() to clean_parts().
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged into master as commit 81ade060c: build provider clean() renamed to clean_parts() (5 files, +9/-9) to distinguish parts cleanup from clean_project() and other build instance cleanup. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #3284 by cjp256 merged: renamed build provider clean() to clean_parts() across 5 files (+9/-9) to clarify it only cleans parts, committed as 81ade060c. Internal refactor, no behaviour change. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged to master: build provider method clean() renamed to clean_parts() to distinguish parts cleanup from clean_project() and other build instance cleanup. Merge commit 81ade060c, 5 files, +9/-9. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into master: renamed build-provider clean() to clean_parts() in commit 81ade060c to clarify that parts cleanup is distinct from other cleanup operations. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. Renames build provider clean() to clean_parts() to clarify scope, as cleanup extends beyond parts. Approved by one reviewer with 100% diff coverage and zero unresolved comments. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Renamed build providers clean() to clean_parts() to clarify method scope. The change maintained 100% diff coverage and was successfully integrated. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#3680
(confidence 70%)
Follow-up work 'commands, parts: add clean command' (abcafbfab, merged via 35ecc5c64) builds on the renamed clean_parts() method.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1779136 build provider support to clean parts | snapcraft (launchpad) | closed | Build-provider support for cleaning selected parts was restored by merged canonical/snapcraft PR #2442 (commit 5546c3aab), without deleting the provider. | |
| #3216 build providers: tweak environment clean detection and logging | snapcraft | merged | Merged #3216 in commit a00e3f52d, improving build-environment clean detection/logging and consolidating clean_project() into one call. | |
| #2474 build providers: remove dead code | snapcraft | merged | Merged PR #2474 as commit 4308dd8d3, removing obsolete build-provider methods left over from legacy cleanbuild support. | |
| #88 fix: clean build provider when no parts are given | craft-application | merged | Merged PR #88 (commit 2d2dd70e, merged into main as ed378fc) by maintainer tigarmo. Adds ProviderService.clean_instances(), converts AppCommand.run_managed to a method taking parsed args, and makes the clean command clean build instances when no parts are given. Fixes #56. | |
| #2442 cli: enable cleaning of parts | snapcraft | merged | Merged #2442 (5546c3aab), restoring snapcraft clean <part-name> with build providers so selected parts can be cleaned without recreating the provider. | |
| #56 "<appname> clean" doesn't remove the build instance | craft-application | closed | Fixed clean behavior: with no parts, craft-provider build instances are removed; part-specific cleans still run inside instances. Resolved by merged PR #88 (commit 2d2dd70e). | |
| #3434 build providers: clean environment if project directory is changed | snapcraft | merged | Merged PR #3434 as commit 805327b65, adding project-directory tracking and cleaning build environments after relocation or project-name reuse. |