build providers: remove dead code
Metadata
Current evaluation
Merged PR #2474 as commit 4308dd8d3, removing obsolete build-provider methods left over from legacy cleanbuild support.
Resolution: closed resolved
Reason: The cleanup was merged into Snapcraft via commit 4308dd8d3. It deleted unused build-provider methods after cleanbuild support was no longer needed.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Remove methods from when build providers supported cleanbuild.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2474 as commit 4308dd8d3, removing obsolete build-provider methods left over from legacy cleanbuild support. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged cleanup in canonical/snapcraft#2474 via commit 4308dd8d3, removing obsolete build-provider methods left from legacy cleanbuild support. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of dead code for legacy cleanbuild support in build providers. Approved by one reviewer, passed CI, and modified three files (+54/-165 lines). | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged maintainer sergiusens' changes to remove dead code from build providers related to legacy cleanbuild support. The update was applied without additional review comments. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2508 Build provider errors | snapcraft | merged | Merged PR #2508 in commit 8d8f411b3, enhancing build-provider error handling across two files (+353/-85 lines). | |
| #3284 build providers: rename clean() -> clean_parts() to clarify scope | snapcraft | merged | Merged into master as commit 81ade060c: build provider clean() renamed to clean_parts() (5 files, +9/-9) to distinguish parts cleanup from clean_project() and other build instance cleanup. | |
| #2515 build providers: support for provider setup | snapcraft | merged | Merged PR #2515 as e4a578823, moving build-provider checks and setup into provider implementations and resolving LP #1821586. | |
| #2374 build providers: destroy on create failures | snapcraft | merged | Merged PR #2374 (commit ec0fbe2be, LP #1792242) adds cleanup so build providers are destroyed when creation/launch fails, preventing VMs from being left running. | |
| #1779136 build provider support to clean parts | snapcraft (launchpad) | closed | Build-provider support for cleaning selected parts was restored by merged canonical/snapcraft PR #2442 (commit 5546c3aab), without deleting the provider. | |
| #3202 build providers: fix base change warning message | snapcraft | merged | Merged PR #3202 as commit c4e3c0ccb, correcting the misleading build-provider warning emitted when a base changes. | |
| #3216 build providers: tweak environment clean detection and logging | snapcraft | merged | Merged #3216 in commit a00e3f52d, improving build-environment clean detection/logging and consolidating clean_project() into one call. | |
| #3290 build providers: unified provider refactoring for provider setup | snapcraft | closed | Closed unmerged; the proposed unified build-provider setup refactor in #3290 was not adopted. | |
| #2275 build providers: use the provider if exported | snapcraft | merged | Merged PR #2275, fixing build-provider selection so an exported provider is used. | |
| #4204 providers: remove deprecated `build_base` parameter | snapcraft | merged | Merged PR #4204 via commit d77b51446, removing the deprecated build_base argument from craft-providers launched_environment() calls. |