build providers: remove dead code
Metadata
Current evaluation
Merged removal of dead code for legacy cleanbuild support in build providers. Approved by one reviewer, passed CI, and modified three files (+54/-165 lines).
Suggested action: —
No scores available.
Issue body
Remove methods from when build providers supported cleanbuild.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of dead code for legacy cleanbuild support in build providers. Approved by one reviewer, passed CI, and modified three files (+54/-165 lines). | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged maintainer sergiusens' changes to remove dead code from build providers related to legacy cleanbuild support. The update was applied without additional review comments. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes removing dead code and deprecated methods related to legacy cleanbuild support in build providers. The cleanup was authored by maintainer sergiusens and successfully integrated. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2374 build providers: destroy on create failures | snapcraft | merged | Merged. Resolves a bug where build providers and VMs remained running after launch failures. Adds cleanup logic and tests across seven files, approved by a reviewer and passing CI checks. | |
| #2508 Build provider errors | snapcraft | merged | Merged after approval and passing CI checks. Resolved build provider errors across two files (+353/-85 lines). Codecov reported 90.62% diff coverage. | |
| #3284 build providers: rename clean() -> clean_parts() to clarify scope | snapcraft | merged | Merged into master. Renames build provider clean() to clean_parts() to clarify scope, as cleanup extends beyond parts. Approved by one reviewer with 100% diff coverage and zero unresolved comments. | |
| #2940 build providers: remove use of cloud-init | snapcraft | merged | Merged changes removing cloud-init from build providers. Refactored to use _run and _push_file methods, isolating initial setup. Approved by reviewer, passed CI, and updated six files. | |
| #5537 docs: update build provider procedures | snapcraft | merged | Merged documentation update to build provider procedures, resolving issue #5519. Approved by two reviewers and passed most CI checks despite minor integration test failures. Changes span four files with 100 lines added and 98 removed. | |
| #2515 build providers: support for provider setup | snapcraft | merged | Merged after approval and passing CI. Implemented provider setup support by relocating checks and initialization logic into provider implementations. Modified ten files (+212/-121 lines) and resolves LP #1821586. | |
| #2282 build providers: cleaner start and launch messaging | snapcraft | merged | Merged changes that clean up start and launch messaging for build providers. Approved by one reviewer, passed CI checks, and modified eight files to address Launchpad issue #1793101. | |
| #2717 build providers: inject core18 instead of core | snapcraft | merged | Merged. Updates build providers to inject core18 instead of core. Approved by one reviewer with passing CI checks. Changes modify two files with seven additions and seven deletions. | |
| #2345 build providers: remove the qemu implementation | snapcraft | merged | Merged the removal of the QEMU build provider implementation, superseded by multipass. The change deleted 1062 lines across 12 files after approval and passing CI checks. | |
| #3215 build providers: use PEP-440 compliant version comparison operator | snapcraft | merged | Merged updates to build providers, replacing manual version checks with pkg_resources for PEP-440 compliance. Approved by reviewer, passed CI, and modified one file (+5/-10). |