v1 plugins: lock godep's dependencies
Metadata
Current evaluation
Merged PR #3285 (commit 7016a1bc3) by cjp256: v1 plugins now checkout pinned revisions of godeps dependencies (e.g. go-toml) after go-get, avoiding go-toml's Go 1.10+ requirement breaking builds.
Resolution: closed resolved
Reason: The PR was approved and merged as commit 7016a1bc3, modifying the v1 plugin setup logic to lock godeps dependencies to specific revisions. A legacy backport of the same change was also merged in #3286.
Evaluated by: mr-cal-bot
No scores available.
Issue body
godeps hasn't been updated in quite some time, but it has
dependencies that need to be locked [1]. Specifically, go-toml
has been updated recently to require newer string interfaces,
requiring go 1.10+, breaking godeps projects on older go
versions.
Since godeps is used for dependency tracking (prior to go
modules), we lock in the dependencies ourselves by checking
out the correct revisions after downloading via go-get.
https://github.com/rogpeppe/godeps/blob/master/dependencies.tsv
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3285 (commit 7016a1bc3) by cjp256: v1 plugins now checkout pinned revisions of godeps dependencies (e.g. go-toml) after go-get, avoiding go-toml's Go 1.10+ requirement breaking builds. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3285 in commit 7016a1bc3 pinned the v1 Godeps plugin's dependencies, including go-toml, to prevent newer Go 1.10+ requirements from breaking older builds. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3285 (commit 7016a1bc3) pinned v1 plugin godeps dependencies, including go-toml, to prevent newer Go 1.10+ requirements from breaking builds on older Go versions. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes locking godeps dependencies, specifically go-toml, to prevent breakage on older Go versions. The update checks out correct revisions after downloading via go-get. Approved by one reviewer and passed all CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix to lock godeps dependencies, specifically go-toml, preventing breakage on older Go versions. The change checks out correct revisions after go-get downloads, ensuring compatibility with pre-module dependency tracking. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#3286
(confidence 92%)
[legacy backport] of this same change, merged for legacy release branches
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3286 [legacy backport] v1 plugins: lock godep's dependencies | snapcraft | merged | Merged as a legacy backport of #3285, pinning v1 plugin godeps dependencies to avoid newer go-toml releases breaking builds on Go older than 1.10. |