[legacy backport] v1 plugins: lock godep's dependencies
Metadata
Current evaluation
Merged as a legacy backport of #3285, pinning v1 plugin godeps dependencies to avoid newer go-toml releases breaking builds on Go older than 1.10.
Resolution: closed resolved
Reason: PR #3286 was merged with commit 7016a1bc3, backporting the dependency-locking change from #3285. It checks out pinned dependency revisions after download, restoring compatibility for older Go versions.
Evaluated by: mr-cal-bot
No scores available.
Issue body
godeps hasn't been updated in quite some time, but it has
dependencies that need to be locked [1]. Specifically, go-toml
has been updated recently to require newer string interfaces,
requiring go 1.10+, breaking godeps projects on older go
versions.
Since godeps is used for dependency tracking (prior to go
modules), we lock in the dependencies ourselves by checking
out the correct revisions after downloading via go-get.
https://github.com/rogpeppe/godeps/blob/master/dependencies.tsv
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as a legacy backport of #3285, pinning v1 plugin godeps dependencies to avoid newer go-toml releases breaking builds on Go older than 1.10. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as the legacy backport of snapcraft#3285, pinning godeps dependencies after download so newer go-toml releases no longer break builds using Go older than 1.10 (commit 7016a1bc3). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3285 via commit 7016a1bc3, locking godeps dependencies for v1 plugins so newer go-toml requirements would not break older Go toolchains. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#3285 (7016a1bc3), locking v1 plugin godeps dependencies, including go-toml, to avoid newer Go requirements. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Locked godeps dependencies to prevent breakage from go-toml requiring Go 1.10+. Dependencies are pinned by checking out correct revisions post-download. Approved with 78 additions and 23 deletions across two files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a legacy backport locking godeps dependencies to prevent go-toml updates from breaking older Go versions. The change checks out specific revisions after go-get to maintain compatibility. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#3285
(confidence 99%)
Original merged change backported by PR #3286.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3285 v1 plugins: lock godep's dependencies | snapcraft | merged | Merged PR #3285 (commit 7016a1bc3) by cjp256: v1 plugins now checkout pinned revisions of godeps dependencies (e.g. go-toml) after go-get, avoiding go-toml's Go 1.10+ requirement breaking builds. | |
| #244 Backport to 1.x: Go plugin creating invalid env | snapcraft | merged | Merged PR #244 backported #161 to 1.x, fixing the Go plugin’s invalid environment by removing unnecessary CGO_LDFLAGS. |