← Back to issue list

[legacy backport] v1 plugins: lock godep's dependencies

View original Github issue

Metadata

Project
snapcraft
Number
#3286
Type
pull request
State
merged
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Merged. Locked godeps dependencies to prevent breakage from go-toml requiring Go 1.10+. Dependencies are pinned by checking out correct revisions post-download. Approved with 78 additions and 23 deletions across two files.

Suggested action:

No scores available.

Issue body

godeps hasn't been updated in quite some time, but it has dependencies that need to be locked [1]. Specifically, go-toml has been updated recently to require newer string interfaces, requiring go 1.10+, breaking godeps projects on older go versions. Since godeps is used for dependency tracking (prior to go modules), we lock in the dependencies ourselves by checking out the correct revisions after downloading via go-get. https://github.com/rogpeppe/godeps/blob/master/dependencies.tsv Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Locked godeps dependencies to prevent breakage from go-toml requiring Go 1.10+. Dependencies are pinned by checking out correct revisions post-download. Approved with 78 additions and 23 deletions across two files.
qwen3.6-35b-a3b-mtp-q6 Merged a legacy backport locking godeps dependencies to prevent go-toml updates from breaking older Go versions. The change checks out specific revisions after go-get to maintain compatibility.
qwen3.6-35b-a3b-mtp-q6 Merged a legacy backport that locks godeps dependencies to prevent breakage on older Go versions. The change pins go-toml and other dependencies by checking out specific revisions after go-get, ensuring compatibility with pre-module Go environments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3285 v1 plugins: lock godep's dependencies snapcraft merged Merged changes locking godeps dependencies, specifically go-toml, to prevent breakage on older Go versions. The update checks out correct revisions after downloading via go-get. Approved by one reviewer and passed all CI checks.
91%