Set ROS_VERSION for rosdep in plugins v1
Metadata
Current evaluation
Merged PR #3313 in commit 1d1b50c81, setting ROS_VERSION for rosdep in plugins v1 so package.xml supports ROS 1/2 conditional dependencies.
Resolution: closed resolved
Reason: The approved change was merged as commit 1d1b50c81, adding ROS_VERSION handling to the v1 ROS plugins and enabling version-specific package.xml dependencies.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
This enables ROS conditional dependencies in `package.xml` such as e.g.
```xml
<build_depend condition="$ROS_VERSION == 1">roscpp</build_depend>
<build_depend condition="$ROS_VERSION == 2">rclcpp</build_depend>
```
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3313 in commit 1d1b50c81, setting ROS_VERSION for rosdep in plugins v1 so package.xml supports ROS 1/2 conditional dependencies. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as 1d1b50c81, setting ROS_VERSION for rosdep in plugins v1 so package.xml dependencies can target ROS 1 or ROS 2 conditionally. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3313 (commit 1d1b50c81): sets ROS_VERSION for rosdep in plugins v1, enabling ROS 1/2 conditional dependencies in package.xml. Later extended to ROS V2 plugins by merged PR #3570 (1fa5484b9). | |
| stealth/space-bunny-alpha | — | closed resolved | PR #3313 by artivis merged as commit 1d1b50c81 "plugins v1: Set ROS_VERSION for rosdep", passing ROS_VERSION to rosdep so ROS 1/2 conditional <build_depend> entries in package.xml resolve correctly. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3313 via commit 1d1b50c81, setting ROS_VERSION for rosdep in v1 plugins so package.xml can select ROS 1 or ROS 2 conditional dependencies. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3313 via commit 1d1b50c81, setting ROS_VERSION for rosdep in plugins v1 and enabling ROS 1/2 conditional dependencies in package.xml. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3313 (1d1b50c81) sets ROS_VERSION for rosdep in plugins v1, enabling ROS 1/2 conditional dependencies in package.xml. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes set the ROS_VERSION environment variable for rosdep in plugins v1. Approved by two reviewers and passing CI, this update enables conditional dependency resolution in package.xml files for ROS 1 and ROS 2. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes set the ROS_VERSION environment variable for rosdep in plugins v1, enabling conditional ROS 1 and ROS 2 dependencies in package.xml. All tests passed and the update was successfully integrated. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3570 ROS V2 plugins: resolve conditional dependencies | snapcraft | merged | Merged PR #3570 in commit 1fa5484b9, enabling ROS V2 plugins to resolve package.xml dependencies conditioned on ROS_VERSION, ROS_DISTRO, or ROS_PYTHON_VERSION. | |
| #183 Backport to 1.x: Catkin plugin: use rosdep for dependency resolution. | snapcraft | merged | Merged into 1.x via PR #183, backporting PR #163 so Catkin uses rosdep instead of manually parsing package.xml dependencies. |