Set ROS_VERSION for rosdep in plugins v1
Metadata
Current evaluation
Merged changes set the ROS_VERSION environment variable for rosdep in plugins v1. Approved by two reviewers and passing CI, this update enables conditional dependency resolution in package.xml files for ROS 1 and ROS 2.
Suggested action: —
No scores available.
Issue body
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
This enables ROS conditional dependencies in `package.xml` such as e.g.
```xml
<build_depend condition="$ROS_VERSION == 1">roscpp</build_depend>
<build_depend condition="$ROS_VERSION == 2">rclcpp</build_depend>
```
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged changes set the ROS_VERSION environment variable for rosdep in plugins v1. Approved by two reviewers and passing CI, this update enables conditional dependency resolution in package.xml files for ROS 1 and ROS 2. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes set the ROS_VERSION environment variable for rosdep in plugins v1, enabling conditional ROS 1 and ROS 2 dependencies in package.xml. All tests passed and the update was successfully integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Sets the ROS_VERSION environment variable for rosdep in plugins v1, enabling conditional dependency resolution in package.xml. Tests passed and the change was accepted. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3570 ROS V2 plugins: resolve conditional dependencies | snapcraft | merged | Merged to master, enabling conditional dependencies in ROS V2 plugins for ROS_VERSION, ROS_DISTRO, and ROS_PYTHON_VERSION. Approved after CI passed and spread tests were updated to cover the feature. | |
| #3324 set ROS_PYTHON_VERSION for rosdep | snapcraft | merged | Merged a two-line update setting ROS_PYTHON_VERSION=2 for the rosdep environment, resolving a harmless defaulting warning. Approved by two reviewers and passed CI checks. |