← Back to issue list

Backport to 1.x: Catkin plugin: use rosdep for dependency resolution.

View original Github issue

Metadata

Project
snapcraft
Number
#183
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged into 1.x via PR #183, backporting PR #163 so Catkin uses rosdep instead of manually parsing package.xml dependencies.

Resolution: closed resolved

Reason: PR #183 was merged into the 1.x branch. It backported PR #163, implemented by commit 87b2e24f6 and merged as 20b33e494, replacing manual dependency parsing with rosdep.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Backport of #163 to 1.x.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged into 1.x via PR #183, backporting PR #163 so Catkin uses rosdep instead of manually parsing package.xml dependencies.
stealth/space-bunny-alpha — closed resolved Merged into 1.x, backporting #163 so the Catkin plugin uses rosdep instead of manual package.xml parsing for dependency resolution.
qwen/qwen3.6-35b-a3b — — Merged backport of #163 to the 1.x branch. The catkin plugin now uses rosdep for dependency resolution, updating three files with 547 additions and 147 deletions.
qwen3.6-35b-a3b-mtp-q6 — — Merged backport of PR #163 to the 1.x branch. The Catkin plugin now uses rosdep for dependency resolution. Maintainer kyrofa integrated the changes directly.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#163 (confidence 100%)

    Original merged implementation backported by PR #183.

Related issues

Issue Project State Summary Similarity
#163 Catkin plugin: use rosdep for dependency resolution snapcraft merged Merged in PR #163 (commit 87b2e24f6), replacing manual Catkin package.xml dependency parsing with rosdep; PR #183 backported the change to Snapcraft 1.x.
85%
#184 Backport to 1.x: Catkin plugin: Refactor build. snapcraft merged PR #184 merged into 1.x, backporting #175’s Catkin build refactor to simplify build logic and dependency handling.
83%
#180 Backport to 1.x: Catkin plugin: Add support for ROS tools. snapcraft merged Merged #180, backporting #152 to the 1.x branch to add ROS tools support to the Catkin plugin.
83%
#1581 catkin plugin: support rosdep pip dependencies snapcraft merged Merged PR #1581 in commit 186ae7f91, adding pip-based rosdep dependency support to the Catkin plugin and fixing LP bug #1683036.
79%
#196 Backport to 1.x: Catkin plugin: Improve cmake path rewrite. snapcraft merged Merged #196 into 1.x, backporting #195’s robust CMake path rewrite so Catkin Config.cmake files correctly target the install directory.
77%
#331 Catkin plugin: Handle rosdep empty and multiple dependencies. snapcraft merged PR #331 merged into snapcraft master as commit 1c1119ce3 (merge e3a2b9d03). It refactored the Catkin plugin's rosdep dependency resolution to handle empty output and multiple packages per line, fixing LP bugs #1548406 and #1548404.
76%
#1548406 Catkin plugin: Can't handle rosdep resolving to nothing snapcraft (launchpad) closed Fixed by canonical/snapcraft#331, merged as commit 1c1119ce3; Catkin now treats empty rosdep output as no dependencies instead of an error.
75%
#181 Backport to 1.x: Resolve FIXME in Catkin plugin snapcraft merged PR #181 merged the #158 Catkin xml2-config FIXME fix into Snapcraft 1.x; implementation commit: 79a1a8297.
73%
#1444 catkin pip support snapcraft closed Catkin gained pip-based rosdep dependency support via merged PR #1581 (commit 186ae7f91), following groundwork in #1479 and #1540.
73%
#1548404 Catkin plugin: Can't handle rosdep resolving to multiple packages snapcraft (launchpad) closed Fixed by ubuntu-core/snapcraft PR #331 (commit 1c1119ce3, 'Catkin plugin: Handle rosdep empty and multiple dependencies'), merged as e3a2b9d03; maintainer ~kyrofa linked the PR when closing the Launchpad bug.
73%