← Back to issue list

package repositories: drop $SNAPCRAFT_APT_RELEASE variable

View original Github issue

Metadata

Project
snapcraft
Number
#3328
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

PR #3328 by cjp256 merged as commit b4df05ac2, removing $SNAPCRAFT_APT_RELEASE handling from package-repositories ahead of the spec's stabilization; spec finalized shortly after in #3333 (23d2ca056).

Resolution: closed resolved

Reason: The PR itself was merged into snapcraft main as b4df05ac2 ('package repositories: drop $SNAPCRAFT_APT_RELEASE variable (#3328)') with approval and no unresolved review comments. The variable no longer appears anywhere in the snapcraft tree, and it was reverted away from the earlier ${release}-based change made in #3057 (9b0b9295b) to pre-stabilization cleanup, finalised in #3333.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Remove prior to stabilization of package-repositories. We can revisit in the future if required. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #3328 by cjp256 merged as commit b4df05ac2, removing $SNAPCRAFT_APT_RELEASE handling from package-repositories ahead of the spec's stabilization; spec finalized shortly after in #3333 (23d2ca056).
stealth/space-bunny-alpha — closed resolved Merged PR #3328 (b4df05ac2), removing package-repositories support for $SNAPCRAFT_APT_RELEASE before stabilization; support may be revisited if required.
qwen/qwen3.6-35b-a3b — — Merged removal of the $SNAPCRAFT_APT_RELEASE variable from package repositories ahead of stabilization. Approved by one reviewer, updating 13 files.
qwen3.6-35b-a3b-mtp-q6 — — Merged removal of the $SNAPCRAFT_APT_RELEASE variable from package repositories ahead of feature stabilization. The change was integrated by maintainer cjp256 to simplify the codebase pending future reassessment.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#3057 (confidence 85%)

    Earlier merged commit 9b0b9295b introduced $SNAPCRAFT_APT_RELEASE for repository suites; #3328 removes that behaviour.

  • Related To: snapcraft#3333 (confidence 80%)

    Merged spec finalization (23d2ca056) shortly after, part of the same package-repositories stabilization cleanup series (also #3322, #3330, #3334, #3336).

  • Related To: snapcraft#3322 (confidence 65%)

    Adjacent cleanup PR dropping $SNAPCRAFT_APT_HOST_ARCH, showing this was a deliberate pre-stabilization removal series.

Related issues

Issue Project State Summary Similarity
#3322 package repositories: drop $SNAPCRAFT_APT_HOST_ARCH variable snapcraft merged Merged PR #3322 removed support for $SNAPCRAFT_APT_HOST_ARCH before package-repositories stabilization in commit 17da34692.
82%
#3057 repo: format $SNAPCRAFT_APT_RELEASE instead of ${release} for suites snapcraft merged Merged as 9b0b9295b: APT repository suites now format $SNAPCRAFT_APT_RELEASE instead of ${release}; schemas also reference $SNAPCRAFT_APT_HOST_ARCH.
78%
#3520 package-repositories: remove experimental flag snapcraft merged PR #3520 by cjp256 merged as commit 0662e6307, dropping the --enable-experimental-package-repositories flag and promoting package-repositories to a stable, GA snapcraft feature (+3/-37, 5 files).
73%
#3647 repo: add package repository handling (CRAFT-846) snapcraft merged Merged package repository and PPA definitions/helpers into snapcraft 7.0 via #3647, porting code from #2911, #3341, #3359, and #3363.
70%