← Back to issue list

specifications: finalization of package repositories spec

View original Github issue

Metadata

Project
snapcraft
Number
#3333
Type
pull request
State
merged
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Merged after addressing reviewer grammar feedback. The update finalizes the package repositories specification for the first stable release, introducing a path property, simplifying key handling, and removing exploratory conjecture.

Suggested action:

No scores available.

Issue body

This updates the spec to match the behavior intended for the first stable release of `package-repositories`. Changes include: - introduction of `path` property to configure repositories using absolute pathing, decoupling from `suites`. - simplified key handling: - always require 40 character key id - find key at snap/keys/<key-id[0:8]>.asc - error if any unused keys are present in snap/keys/ - add note on how to get GPG key ID from key file. - removed exploratory conjecture about `name` field. - other minor cleanup. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after addressing reviewer grammar feedback. The update finalizes the package repositories specification for the first stable release, introducing a path property, simplifying key handling, and removing exploratory conjecture.
qwen3.6-35b-a3b-mtp-q6 Merged finalization of the package repositories specification. Updates add a path property for absolute configuration, simplify GPG key handling to require 40-character IDs, remove speculative content. Approved after grammar fixes.
qwen3.6-35b-a3b-mtp-q6 Merged the final package repositories specification for the first stable release. Changes include a new path property, simplified GPG key handling, removal of speculative fields, and minor cleanup. Approved after minor grammar adjustments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3245 specifications: minor cleanup for package-repositories snapcraft merged Merged minor cleanup for package-repositories specifications. Incorporated user feedback hints and improved formatting. Approved by one reviewer with no unresolved comments, yielding 36 additions and 25 deletions in one file.
75%
#3074 package-repositories: draft spec and cleanup snapcraft merged Merged draft package-repositories specification, schema cleanup removing a reserved name, and CLI gating behind an experimental flag. Approved by one reviewer. Changes span 14 files with 344 additions and 47 deletions.
74%