← Back to issue list

specifications: minor cleanup for package-repositories

View original Github issue

Metadata

Project
snapcraft
Number
#3245
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #3245 as commit 1594cf4f4, adding user-feedback hints and tidying package-repositories specification formatting.

Resolution: closed resolved

Reason: PR #3245 was approved and merged as commit 1594cf4f4. The change added usability hints and cleaned up the package-repositories specification.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Add some hints based off feedback from users and tidy up some formatting. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #3245 as commit 1594cf4f4, adding user-feedback hints and tidying package-repositories specification formatting.
stealth/space-bunny-alpha — closed resolved Merged #3245 (commit 1594cf4f4), adding user-feedback hints and tidying package-repositories specification formatting (+36/-25).
qwen/qwen3.6-35b-a3b — — Merged minor cleanup for package-repositories specifications. Incorporated user feedback hints and improved formatting. Approved by one reviewer with no unresolved comments, yielding 36 additions and 25 deletions in one file.
qwen3.6-35b-a3b-mtp-q6 — — Merged minor cleanup and formatting updates for package-repositories specifications, incorporating user feedback. The maintainer accepted the changes directly without additional review comments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3333 specifications: finalization of package repositories spec snapcraft merged Merged PR #3333 as 23d2ca056, finalizing the package-repositories spec for its first stable release with path support, stricter key handling, and wording cleanup.
80%
#3248 specifications: fix typo in package-repositories snapcraft closed Closed unmerged in favor of #3249, whose equivalent package-repositories typo fix was selected instead.
79%
#3072 schema: minor tweaks/fixes for package-repositories snapcraft merged Merged #3072 as d2c0efe09, refining package-repositories validation, optional names, empty-field coverage, and missing-URL test behavior.
78%
#3074 package-repositories: draft spec and cleanup snapcraft merged PR #3074 merged the draft package-repositories spec, removed the reserved schema name, and gated the feature behind --enable-experimental-package-repositories.
73%