← Back to issue list

cli,plugins: assume that core22 base wants v2 plugins.

View original Github issue

Metadata

Project
snapcraft
Number
#3337
Type
pull request
State
merged
Author
xnox
Labels
Created
Updated
Closed

Current evaluation

Merged a fix updating the CLI and plugins to default to v2 plugins for core22 and newer bases, resolving a legacy v1 fallback. The change includes a test for future cores, passed CI, and received reviewer approval.

Suggested action:

No scores available.

Issue body

When trying to use build-base core22, some portions of cli/plugins defaulted to legacy/v1 plugins, instead of v2. Use a list of old cores, and assume anything new to be modern/v2. Add a test for a "future core2y" to use v2 plugins. - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - no, fails on groovy with new pyflakes? - [x] Have you successfully run `./runtests.sh tests/unit`? - no, fails on groovy, as it's trying to run pytest (python2) not pytest-3 (python3)?

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix updating the CLI and plugins to default to v2 plugins for core22 and newer bases, resolving a legacy v1 fallback. The change includes a test for future cores, passed CI, and received reviewer approval.
qwen3.6-35b-a3b-mtp-q6 Merged fix to default plugins to v2 for core22 and newer bases. Replaced legacy v1 defaults by checking against a list of older cores and added a test for future core releases.
qwen3.6-35b-a3b-mtp-q6 Merged fix ensuring core22 and newer bases default to v2 plugins instead of legacy v1. Implements a version check against old core lists and adds a test for future cores. Resolves plugin version mismatch during builds.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3870 plugins command: support for core22 snapcraft merged Merged changes adding core22 support to the plugins command and clarifying base selection messages. Approved by a reviewer, passed CI, and integrated into main despite a minor 0.04% coverage decrease.
80%
#3079 cli: add plugin help for core20 snapcraft merged Merged updates to add core20 plugin help, fix python and nil plugin help for v2, enable the click pager, and default base loading to core20. Approved by reviewer and passed all CI checks.
72%
#3082 cli: add list-plugins for core20 snapcraft merged Merged addition of the list-plugins CLI command for core20. Changes remove an integration test and adapt the help command structure. Approved by one reviewer with passing CI checks.
70%