← Back to issue list

cli,plugins: assume that core22 base wants v2 plugins.

View original Github issue

Metadata

Project
snapcraft
Number
#3337
Type
pull request
State
merged
Author
xnox
Labels
—
Created
Updated
Closed

Current evaluation

Merged in commit 58cb9e3cb, making core22 and future core2y build bases default to v2 plugins and adding regression coverage.

Resolution: closed resolved

Reason: PR snapcraft#3337 was merged, resolving incorrect v1 plugin defaults for core22 and future core2y bases.

Evaluated by: mr-cal-bot

No scores available.

Issue body

When trying to use build-base core22, some portions of cli/plugins defaulted to legacy/v1 plugins, instead of v2. Use a list of old cores, and assume anything new to be modern/v2. Add a test for a "future core2y" to use v2 plugins. - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - no, fails on groovy with new pyflakes? - [x] Have you successfully run `./runtests.sh tests/unit`? - no, fails on groovy, as it's trying to run pytest (python2) not pytest-3 (python3)?

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in commit 58cb9e3cb, making core22 and future core2y build bases default to v2 plugins and adding regression coverage.
stealth/space-bunny-alpha — closed resolved Merged PR #3337 in commit 58cb9e3cb: core22 and future core2y bases now default to v2 plugins, with regression coverage for future bases.
qwen/qwen3.6-35b-a3b — — Merged a fix updating the CLI and plugins to default to v2 plugins for core22 and newer bases, resolving a legacy v1 fallback. The change includes a test for future cores, passed CI, and received reviewer approval.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix to default plugins to v2 for core22 and newer bases. Replaced legacy v1 defaults by checking against a list of older cores and added a test for future core releases.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3870 plugins command: support for core22 snapcraft merged Merged #3870 as commit 3836719a9, adding core22 support to the plugins command and clarifying why a base is selected.
80%