← Back to issue list

plugins command: support for core22

View original Github issue

Metadata

Project
snapcraft
Number
#3870
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged changes adding core22 support to the plugins command and clarifying base selection messages. Approved by a reviewer, passed CI, and integrated into main despite a minor 0.04% coverage decrease.

Suggested action: —

No scores available.

Issue body

And clarify message on why a base is picked. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? ----- CRAFT-1256

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged changes adding core22 support to the plugins command and clarifying base selection messages. Approved by a reviewer, passed CI, and integrated into main despite a minor 0.04% coverage decrease.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Adds core22 support to the plugins command and clarifies base selection messaging. Authored by maintainer sergiusens. Codecov flagged a minor coverage decrease but approved the merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main as PR #3870. Implemented core22 support for the plugins command and clarified base selection messaging. Changes passed review with 91.66% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3337 cli,plugins: assume that core22 base wants v2 plugins. snapcraft merged Merged a fix updating the CLI and plugins to default to v2 plugins for core22 and newer bases, resolving a legacy v1 fallback. The change includes a test for future cores, passed CI, and received reviewer approval.
80%
#4657 feat(core22): maven plugin snapcraft merged Merged the core22 maven plugin. Approved by three reviewers with full test coverage. Despite two unresolved review comments and a note about broken tests, the feature was successfully integrated.
77%
#2370 ant plugin: add support for bases snapcraft merged Merged after approval and CI. Adds base support to the ant plugin, restricting it to core16 and core18. Modifies 14 files with 83.54% diff coverage.
77%
#2362 python plugin: add support for bases snapcraft merged Merged. Updated the Python plugin to support core16 and core18 bases. Approved by reviewer, passed CI, and migrated tests to spread with 97.36% coverage.
77%
#3079 cli: add plugin help for core20 snapcraft merged Merged updates to add core20 plugin help, fix python and nil plugin help for v2, enable the click pager, and default base loading to core20. Approved by reviewer and passed all CI checks.
76%
#2373 rust plugin: add support for bases snapcraft merged Merged update to the Rust plugin adding base support for core16 and core18. Resolves Launchpad bug #1798681. Approved, passed CI, and achieved 100% diff coverage with a net zero line change across 23 files.
76%
#2346 ruby plugin: add support for base snapcraft merged Updates the Ruby plugin to be base-aware, restricting support to core16 and core18. Resolves bug LP: #1794800. Merged after approval, passing CI, and 100% diff coverage.
74%
#3082 cli: add list-plugins for core20 snapcraft merged Merged addition of the list-plugins CLI command for core20. Changes remove an integration test and adapt the help command structure. Approved by one reviewer with passing CI checks.
74%
#223 packages: package filter for core22 craft-parts merged Merged changes applying the core20 package filter behavior to core22. Approved by one reviewer, passed CI checks, and modified one file (+41/-1).
74%
#2357 scons plugin: add support for bases snapcraft merged Merged. Updated the Scons plugin to support core16 and core18 bases. Approved by reviewer, passed CI, and modified 105 additions and 18 deletions across five files.
74%