← Back to issue list

repo: move apt ppa helpers into apt_ppa module

View original Github issue

Metadata

Project
snapcraft
Number
#3341
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/snapcraft#3341 as commit 68ec9d3c9, extracting apt PPA helpers from _deb and expanding focused unit-test coverage.

Resolution: closed resolved

Reason: The approved PR was merged as commit 68ec9d3c9 with no unresolved review comments. The refactor separated PPA helpers from _deb and added targeted unit tests.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This decouples the apt ppa helpers from the _deb module and improves test coverage of the specific ppa helper functions. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#3341 as commit 68ec9d3c9, extracting apt PPA helpers from _deb and expanding focused unit-test coverage.
stealth/space-bunny-alpha — closed resolved Merged in snapcraft/snapcraft#3341 as commit 68ec9d3c9, extracting apt PPA helpers from _deb into apt_ppa and expanding their unit-test coverage.
stealth/space-bunny-alpha — closed resolved Merged in snapcore/snapcraft#3341 (commit 68ec9d3c9), moving apt PPA helpers into the apt_ppa module and improving unit-test coverage.
qwen/qwen3.6-35b-a3b — — Merged refactoring that moves apt ppa helper functions from the _deb module into a dedicated apt_ppa module. The change improves test coverage, passes CI validation, and received reviewer approval.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes that decouple apt ppa helpers from the _deb module by relocating them to a dedicated apt_ppa module, improving code structure and test coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3647 repo: add package repository handling (CRAFT-846) snapcraft merged Merged package repository and PPA definitions/helpers into snapcraft 7.0 via #3647, porting code from #2911, #3341, #3359, and #3363.
72%
#1192 repo: refactor into a package. snapcraft merged Merged as 1e2cd8a2e, refactoring snapcraft.repo into a package and making BaseRepo easier to extend for non-apt/deb functionality.
71%
#1758 tests: move the ppa test trigger to lxd snapcraft merged Merged snapcore/snapcraft#1758 (commit 3524514e9), moving the PPA test trigger from Docker to LXD after debugging showed the PPA correctly failed to build the prior day's snap.
71%