← Back to issue list

project loader, schema: add advanced grammar support for build-environment

View original Github issue

Metadata

Project
snapcraft
Number
#3350
Type
pull request
State
merged
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Merged into master. Adds advanced grammar support for build-environment to the project loader and schema. Approved by one reviewer with 90.9% diff coverage. A minor plainbox unit test failure was noted but did not block the merge.

Suggested action:

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into master. Adds advanced grammar support for build-environment to the project loader and schema. Approved by one reviewer with 90.9% diff coverage. A minor plainbox unit test failure was noted but did not block the merge.
qwen3.6-35b-a3b-mtp-q6 Merged into master, adding advanced grammar support for build-environment in the project loader and schema. Accepted despite a failing plainbox test and minor coverage drop. Grammar updates were split into a separate pull request.
qwen3.6-35b-a3b-mtp-q6 Merged into master, adding advanced grammar support for build-environment in the project loader and schema. A failing plainbox unit test was noted but did not block integration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3360 project loader: advanced grammar support for lists snapcraft merged Merged after approval and passing CI. The update refactors the project loader to process lists instead of sets, preserving ordering and supporting non-string primitives. Changes include GrammarProcessor updates, part grammar adjustments, and corresponding test modifications.
76%
#1511 project_loader: support grammar on build-packages snapcraft merged Merged: Added grammar support for build-packages at part and global levels. Approved by one reviewer, passed CI, and modified 19 files. Builds on issue #1492 and depends on PR #1509.
75%
#1504 project loader: refactor into package snapcraft merged Merged a refactor moving the project loader into a dedicated package, relocating PartsConfig logic and the schema validator, and introducing a base error class. Modified 16 files to advance issue #1492.
74%
#3357 project schema tests: ensure json format checkers are loaded snapcraft merged Merged a fix resolving project schema test failures when run individually. The change imports missing JSON format checkers and suppresses related warnings. Approved by one reviewer, passed CI, and applied with a minimal two-line change.
72%
#1509 project_loader: process stage package grammar snapcraft merged Merged. Moved stage package grammar processing to project_loader, creating a dedicated processor for part properties. Raw YAML is preserved for state tracking. Approved by one reviewer, passed CI, and modified 26 files.
70%