← Back to issue list

project_loader: support grammar on build-packages

View original Github issue

Metadata

Project
snapcraft
Number
#1511
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 4674a5738, adding grammar support for build-packages globally and per part after prerequisite #1509.

Resolution: closed resolved

Reason: PR #1511 was approved and merged into Snapcraft as commit 4674a5738, implementing grammar-powered build-packages at both project and part levels.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Currently Snapcraft only supports grammar-powered stage-packages. This PR makes another good chunk of progress on #1492 by adding support for grammar-powered build-packages as well, both at the part-level and global. Note that this PR depends upon #1509, but was proposed anyway as I'm leaving for a few days. It also may give the other PR more context.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 4674a5738, adding grammar support for build-packages globally and per part after prerequisite #1509.
stealth/space-bunny-alpha — closed resolved Merged in commit 4674a5738 via #1511, adding grammar-powered build-packages at part and global levels after prerequisite #1509; advanced filtering continued in #1492.
stealth/space-bunny-alpha — closed resolved Merged in commit 4674a5738 (PR #1511), adding grammar support for build-packages at part and global levels after prerequisite PR #1509.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#1511 via commit 4674a5738, adding grammar-powered build-packages at part and global levels and building on #1509.
qwen/qwen3.6-35b-a3b — — Merged: Added grammar support for build-packages at part and global levels. Approved by one reviewer, passed CI, and modified 19 files. Builds on issue #1492 and depends on PR #1509.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Added grammar support for build-packages at part and global levels in Snapcraft. Advances issue #1492 and depends on PR #1509. Maintainer approved and suggested future refactoring for build tools processing.

Update history

No update history recorded yet.

Related work

  • Blocked By: canonical/snapcraft#1509 (confidence 100%)

    Stated prerequisite; its project-loader stage-package grammar processing was merged first as commit 82e27706d.

  • Related To: canonical/snapcraft#1492 (confidence 95%)

    Tracking issue for advanced build-package filtering that this merged PR explicitly advanced.

Related issues

Issue Project State Summary Similarity
#1671238 please support selectors in build-packages too snapcraft (launchpad) closed Feature request for grammar/selectors on build-packages was implemented: PR #1509 (commit 82e27706d) moved stage-package grammar processing into project_loader, and PR #1511 (commit 4674a5738) added grammar support for build-packages globally and per part.
77%
#1782 project_loader: support grammar on architectures snapcraft closed Closed unmerged after review requested further discussion; equivalent architecture-grammar support later landed via merged PR #2080 (c60ac3891).
75%
#1509 project_loader: process stage package grammar snapcraft merged Merged #1509 in commit 82e27706d, moving stage-package grammar processing from pluginhandler into project_loader while retaining raw YAML for state tracking.
71%
#3652 parts: support for grammar parsing snapcraft merged Merged #3652 via commit cfbe60ac4 (merge 7708b7261), adding Craft Grammar parsing for part source, package, environment, and snap fields.
71%
#3350 project loader, schema: add advanced grammar support for build-environment snapcraft merged Merged as ef2fa17e1, adding advanced-grammar support for build-environment to the project loader and schema.
70%