Fix colcon v1 workspace sourcing
Metadata
Current evaluation
Merged a fix correcting colcon v1 workspace sourcing to use the proper overlay script, resolving a build repetition issue. Approved by two reviewers, passed CI, and applied a minimal two-file change per ROS2 documentation.
Suggested action: —
No scores available.
Issue body
Currently colcon v1 sources the wrong script for the overlay workspace preventing from running twice the build. This PR fixes this by sourcing the appropriate script as per [the documentation](https://index.ros.org/doc/ros2/Tutorials/Workspace/Creating-A-Workspace/#source-the-overlay).
related LP:#1866719
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix correcting colcon v1 workspace sourcing to use the proper overlay script, resolving a build repetition issue. Approved by two reviewers, passed CI, and applied a minimal two-file change per ROS2 documentation. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for colcon v1 workspace sourcing. Corrects the overlay workspace script path to prevent build failures when running twice. Aligns sourcing behavior with official ROS2 documentation. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for colcon v1 workspace sourcing. The change corrects the overlay workspace script path, resolving a bug that prevented running the build twice. Contributed by artivis. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3994 core22 colcon plugin: re-source environment after installation | snapcraft | merged | Merged fix for core22 colcon plugin that re-sources ROS 2 environment post-installation to resolve custom interface build failures. Added spread tests and package state restoration. Approved by two reviewers and merged. | |
| #2456 plugins: add colcon plugin | snapcraft | merged | Merged the colcon plugin for ROS2 builds, resolving LP: #1805213. Added as a beta feature, the change was approved by two reviewers, passed CI with 100% diff coverage, and introduced 2120 lines across 16 files. | |
| #3638 colcon v2: forward cmake args | snapcraft | merged | Merged a fix ensuring colcon-cmake-args are forwarded to the build command in the Colcon v2 plugin. Approved by reviewer, passed CI, and achieved 100% diff coverage. | |
| #3566 ROS 2 plugins v2 misc fixes | snapcraft | merged | Merged after resolving conflicts and passing CI. Fixes ROS 2 plugins v2 by updating the colcon install path, resolving local packages during staging by removing the COLCON_IGNORE marker, and adding spread tests. |