Fix colcon v1 workspace sourcing
Metadata
Current evaluation
Merged #3358 as commit 19f2af730, fixing colcon v1 workspace activation to source the documented overlay script so builds can run twice.
Resolution: closed resolved
Reason: PR #3358 was approved and merged as commit 19f2af730. It corrects colcon v1 overlay workspace sourcing, resolving the failure to run the build twice.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Currently colcon v1 sources the wrong script for the overlay workspace preventing from running twice the build. This PR fixes this by sourcing the appropriate script as per [the documentation](https://index.ros.org/doc/ros2/Tutorials/Workspace/Creating-A-Workspace/#source-the-overlay).
related LP:#1866719
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #3358 as commit 19f2af730, fixing colcon v1 workspace activation to source the documented overlay script so builds can run twice. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3358 in commit 19f2af730, correcting colcon v1 to source the documented overlay workspace script so builds can run twice. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3358 (19f2af730), fixing colcon v1 workspace sourcing to use the documented overlay script so builds can run twice. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3358 (19f2af730): corrected colcon v1 workspace sourcing to use the documented overlay script, allowing the build to run twice. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix correcting colcon v1 workspace sourcing to use the proper overlay script, resolving a build repetition issue. Approved by two reviewers, passed CI, and applied a minimal two-file change per ROS2 documentation. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for colcon v1 workspace sourcing. Corrects the overlay workspace script path to prevent build failures when running twice. Aligns sourcing behavior with official ROS2 documentation. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2486 colcon plugin: support build-time chaining | snapcraft | merged | Merged #2486 as 60c3c9b18, restoring colcon build-time workspace chaining through setup files; fixes LP #1816565. |