← Back to issue list

colcon plugin: support build-time chaining

View original Github issue

Metadata

Project
snapcraft
Number
#2486
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged #2486 as 60c3c9b18, restoring colcon build-time workspace chaining through setup files; fixes LP #1816565.

Resolution: closed resolved

Reason: The approved PR was merged as commit 60c3c9b18. It reworked the colcon plugin to rely on setup files instead of environment variables, resolving LP #1816565.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- Until recently, colcon had a bug that caused it to not chain workspaces at build-time. That was recently fixed in a way that broke the colcon plugin. This PR fixes [LP: #1816565](https://bugs.launchpad.net/snapcraft/+bug/1816565) by reworking the plugin to rely more on the setup files and less on environment variables to avoid this issue in the future.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #2486 as 60c3c9b18, restoring colcon build-time workspace chaining through setup files; fixes LP #1816565.
stealth/space-bunny-alpha — closed resolved Merged PR #2486 (commit 60c3c9b18) fixing LP: #1816565: colcon plugin reworked to source colcon setup files instead of environment variables, restoring build-time workspace chaining.
stealth/space-bunny-alpha — closed resolved Merged snapcore/snapcraft#2486 (60c3c9b18), fixing LP: #1816565 by using colcon setup files instead of environment variables for build-time workspace chaining.
qwen/qwen3.6-35b-a3b — — Merged PR fixing the colcon plugin to support build-time chaining. Resolves a regression by relying on setup files instead of environment variables, addressing Launchpad bug #1816565. Approved and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for the colcon plugin to support build-time chaining. The update relies on setup files instead of environment variables, resolving a regression from a colcon workspace chaining fix.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1816565 colcon tests fail snapcraft (launchpad) closed Colcon test failures were resolved by snapcore/snapcraft#2486 (commit 60c3c9b18), restoring build-time workspace chaining through Colcon setup files.
77%
#3358 Fix colcon v1 workspace sourcing snapcraft merged Merged #3358 as commit 19f2af730, fixing colcon v1 workspace activation to source the documented overlay script so builds can run twice.
76%
#2670 Plugin colcon: forward parallel build count snapcraft merged Merged as bd0480688; the colcon plugin now forwards parallel-build-count and disable-parallel settings to the colcon build command.
72%
#1434 feat: colcon plugin craft-parts merged Merged PR #1434 added a reusable colcon build plugin, enabling shared colcon integration for tools such as Rockcraft and Snapcraft.
72%
#4502 Colcon plugin: use release build by default snapcraft merged Merged PR #4502 as commit b6c5a60b9, making Colcon use CMake Release builds by default while preserving explicit user overrides.
71%