← Back to issue list

colcon plugin: support build-time chaining

View original Github issue

Metadata

Project
snapcraft
Number
#2486
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged PR fixing the colcon plugin to support build-time chaining. Resolves a regression by relying on setup files instead of environment variables, addressing Launchpad bug #1816565. Approved and passed CI.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- Until recently, colcon had a bug that caused it to not chain workspaces at build-time. That was recently fixed in a way that broke the colcon plugin. This PR fixes [LP: #1816565](https://bugs.launchpad.net/snapcraft/+bug/1816565) by reworking the plugin to rely more on the setup files and less on environment variables to avoid this issue in the future.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged PR fixing the colcon plugin to support build-time chaining. Resolves a regression by relying on setup files instead of environment variables, addressing Launchpad bug #1816565. Approved and passed CI.
qwen3.6-35b-a3b-mtp-q6 Merged a fix for the colcon plugin to support build-time chaining. The update relies on setup files instead of environment variables, resolving a regression from a colcon workspace chaining fix.
qwen3.6-35b-a3b-mtp-q6 Merged a fix for the colcon plugin to support build-time chaining. The update reworks the plugin to use setup files instead of environment variables, resolving LP: #1816565 and restoring compatibility with recent colcon changes.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3638 colcon v2: forward cmake args snapcraft merged Merged a fix ensuring colcon-cmake-args are forwarded to the build command in the Colcon v2 plugin. Approved by reviewer, passed CI, and achieved 100% diff coverage.
74%
#4502 Colcon plugin: use release build by default snapcraft merged Merged changes to default the Colcon plugin to Release builds, reducing snap executable size and debug symbols. Approved by reviewers, passed CI, and declined backporting to 7.x.
73%
#2456 plugins: add colcon plugin snapcraft merged Merged the colcon plugin for ROS2 builds, resolving LP: #1805213. Added as a beta feature, the change was approved by two reviewers, passed CI with 100% diff coverage, and introduced 2120 lines across 16 files.
72%
#1622 fix(colcon): add missing build-packages to colcon craft-parts merged Merged after resolving a changelog conflict. Fixes colcon build failures by adding missing build dependencies (make and python3-colcon-recursive-crawl) that are only recommended by default apt packages. Approved by reviewers and passed all CI checks.
71%
#1434 feat: colcon plugin craft-parts merged Merged the colcon plugin into craft-parts to enable cross-tool reuse. Approved by four reviewers, the branch was rebased to resolve a conventional commit job conflict, passed CI checks, and integrated successfully.
71%