plugins v1: move build base test in v1 plugins to base class
Metadata
Current evaluation
Merged PR #3389 (commit b0d696f07): the per-plugin build-base check for V1 plugins was moved into the V1 Plugin base class constructor, removing duplicated checks across 23 files (+78/-146).
Resolution: closed resolved
Reason: The PR itself was merged into snapcraft's main branch as commit b0d696f07, with one approving review, relocating build-base validation into the base-class constructor as described in the description.
Evaluated by: mr-cal-bot
No scores available.
Issue body
V1 plugins can be used only if the build base is core, core16 or
core18. As an additional sanity check, each plugin tests for base
consistency. To clean that up, move the base check from each
individual plugin to the V1 plugin base class constructor.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3389 (commit b0d696f07): the per-plugin build-base check for V1 plugins was moved into the V1 Plugin base class constructor, removing duplicated checks across 23 files (+78/-146). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #3389 via b0d696f07: V1 plugin build-base validation moved from individual plugins to the base-class constructor, reducing duplication across 23 files. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged refactoring that moves build base validation to the V1 plugin base class constructor. The change reduces duplication across 23 files while maintaining checks for core, core16, and core18 bases. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Consolidated build base consistency checks from individual V1 plugins into the V1 plugin base class constructor. Reviewer suggested alternative compatibility checks, but the refactoring was accepted and merged as proposed. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2308 plugins: remove the copy plugin when using a base | snapcraft | merged | Merged PR #2308 via commit 360453fa6, removing the copy plugin for base-based builds while preserving and testing legacy no-base compatibility. | |
| #3013 plugins: use v1 import path for all plugins | snapcraft | merged | Merged PR #3013 (commit ece92e986), standardizing all plugin imports on the v1 path across 25 files (+86/-94). |