[feature] ROS plugins v2 out of source tree builds
Metadata
Current evaluation
Merged #3405 (commit c074de797), enabling ROS plugins v2 out-of-source builds so snapcraft.yaml can be placed in a ROS package root.
Resolution: closed resolved
Reason: PR #3405 was merged, with the change recorded in commit c074de797. It builds on out-of-source support from #3392 and replaces the earlier attempt in #3348.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This PR changes the ROS plugins v2 so that they use the 'out of source tree builds' feature introduced in https://github.com/snapcore/snapcraft/pull/3392.
It allows for distributing the `snapcraft.yaml` config file directly alongside a ROS package (in the package root directory) whereas it can currently only be distributed with a ROS workspace.
Replaces a previous attempt https://github.com/snapcore/snapcraft/pull/3348.
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `./runtests.sh static`?
- [X] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #3405 (commit c074de797), enabling ROS plugins v2 out-of-source builds so snapcraft.yaml can be placed in a ROS package root. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit c074de797, adding out-of-source-tree build support (get_out_of_source_build) to the ROS/colcon plugins v2, so snapcraft.yaml can live in a ROS package root. Builds on #3392 and replaces #3348. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3405 (1df75d9) adds out-of-source-tree builds to ROS plugins v2, so snapcraft.yaml can ship inside a ROS package root. Builds on #3392 and replaces the closed #3348. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #3405, enabling out-of-source builds in ROS plugins v2 so snapcraft.yaml can sit in a ROS package root. Replaces #3348 and builds on merged #3392. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3405, enabling ROS plugins v2 out-of-source builds so snapcraft.yaml can live in a ROS package root, replacing #3348. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Enables out-of-source-tree builds for ROS plugins v2, allowing snapcraft.yaml placement in the package root. Replaces PR #3348. Approved by two reviewers and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Updates ROS plugins v2 to use out-of-source tree builds, permitting snapcraft.yaml placement in the package root rather than a workspace. Replaces PR #3348. Accepted with a 0.01% coverage decrease. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcore/snapcraft#3392
(confidence 100%)
Added the out-of-source build support used by the ROS plugins v2 changes.
-
Superseded By:
snapcore/snapcraft#3348
(confidence 100%)
The earlier ROS out-of-source implementation was replaced by merged PR #3405.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3392 plugins v2: add support for out of source tree builds | snapcraft | merged | Merged PR #3392 (commit 21c486876) added an out_of_source_build property to PluginV2, skipping source copying and switching the Meson and CMake v2 plugins to out-of-tree builds. | |
| #3566 ROS 2 plugins v2 misc fixes | snapcraft | merged | Merged #3566 via 6f80a4cee, fixing ROS 2 v2 install paths and local-package staging, with new spread tests. | |
| #1902090 ROS plugins should support building a single ROS package in addition to a workspace | snapcraft (launchpad) | closed | ROS plugins V2 gained single-package build support in merged PR snapcore/snapcraft#3405 (commit c074de797). |