← Back to issue list

ROS plugins use plugins' build directory

View original Github issue

Metadata

Project
snapcraft
Number
#3348
Type
pull request
State
closed
Author
artivis
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged by author artivis (2020-12-15) in favor of a different scheme. Equivalent out-of-source ROS builds shipped via #3392 (21c486876) and ROS plugins PR #3405 (c074de797).

Resolution: closed superseded

Reason: The author closed the PR without merging, stating they went with a different scheme. That scheme landed in merged PR #3392 (commit 21c486876), which added an `out_of_source_build` property to PluginV2, and PR #3405 (commit c074de797), which applied it to the ROS v2 plugins — achieving the same goal of allowing snapcraft.yaml alongside a ROS package.

Evaluated by: mr-cal-bot

No scores available.

Issue body

ROS plugins use the plugins' build directory introduced in #3347 to dump their build artifact while the `part-name/build` directory is only used to fetch source files. This allows for distributing the `snapcraft.yaml` config file directly alongside a ROS package (in the package root directory) whereas it can currently only be distributed with a ROS workspace. Follows #3347. Signed-off-by: artivis deray.jeremie@gmail.com - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged by author artivis (2020-12-15) in favor of a different scheme. Equivalent out-of-source ROS builds shipped via #3392 (21c486876) and ROS plugins PR #3405 (c074de797).
stealth/space-bunny-alpha — closed superseded PR #3348 (ROS plugins use the plugin build dir from #3347) was closed unmerged by artivis on 2020-12-15 in favour of a different scheme: #3392 and merged #3405 (c074de797) added ROS plugins v2 out-of-source builds.
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of a different build-directory scheme; #3347 was later superseded by #3392, which added out-of-tree build support.
qwen/qwen3.6-35b-a3b — — Closed by the author as abandoned. The changes were superseded by an alternative implementation in pull request #3347, which adopted a different build directory scheme for ROS plugins.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by an alternative scheme in pull request #3347. The proposed ROS plugin build directory routing was not merged.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#3392 (confidence 95%)

    Merged PR adding out_of_source_build support to plugins v2 (commit 21c486876), the alternative scheme the author referenced when closing.

  • Superseded By: canonical/snapcraft#3405 (confidence 93%)

    Merged PR 'ros v2 plugins: out of source tree builds' (commit c074de797) delivering the same capability for the ROS plugins.

  • Related To: canonical/snapcraft#3347 (confidence 90%)

    Parent PR that introduced the extra plugin build directory; also closed unmerged in favor of #3392.

Related issues

Issue Project State Summary Similarity
#3664 ROS plugins v2: respect source-subdir key snapcraft merged Merged PR #3664, with commit 09eb744e5, made ROS v2 Colcon/catkin plugins respect source-subdir, removed a redundant dependency, and added subdirectory tests.
74%