Fix a few licenses in ros-related test files
Metadata
Current evaluation
PR #3409 by artivis merged (approved by 2 reviewers), correcting mismatched license declarations in ROS-related test package.xml files (+12/-12 across 12 files). Follow-up to merged #3405.
Resolution: closed resolved
Reason: The pull request itself was merged into snapcraft after two approving reviews and no unresolved comments, applying the license corrections to the ROS test fixtures. It was explicitly framed as the follow-up to the already-merged PR #3405.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Here is the follow-up PR to https://github.com/snapcore/snapcraft/pull/3405 fixing a few licenses in ROS-related test files. The license declared in a few `package.xml` did not match those in sources.
See [this discussion](https://github.com/snapcore/snapcraft/pull/3405#discussion_r554162049) for reference.
Signed-off-by: artivis <deray.jeremie@gmail.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #3409 by artivis merged (approved by 2 reviewers), correcting mismatched license declarations in ROS-related test package.xml files (+12/-12 across 12 files). Follow-up to merged #3405. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcraft#3409 as commit 1f3f08f69, correcting mismatched package.xml license declarations in 12 ROS-related test files. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3409 as commit 1f3f08f69, aligning declared licenses in 12 ROS-related test files with their sources; follow-up to #3405. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to fix license mismatches in ROS-related test files by aligning package.xml declarations with source code. Approved by two reviewers, passed CI, and updated 12 files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a follow-up to PR #3405 correcting license declarations in ROS-related test files. The update aligned package.xml metadata with actual source code licenses, resolving compliance mismatches in the test suite. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#3405
(confidence 88%)
Predecessor PR that introduced the mismatched package.xml licenses; this PR fixes the ones left over, referencing a review discussion on that PR.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #515 Clean up the ROS example test. | snapcraft | merged | Merged PR #515 as commit 77fd8fffc, cleaning up the ROS example test with 36 additions and 24 deletions across two files. |