← Back to issue list

cli: enable SNAPCRAFT_TARGET_ARCH envvar matching --target-arch

View original Github issue

Metadata

Project
snapcraft
Number
#3415
Type
pull request
State
closed
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged with changes requested. Superseded by merged PR #3414 (ff2cd96bb), which exported SNAPCRAFT_TARGET_ARCH in the project loader's build environment instead of adding a CLI envvar option.

Resolution: closed superseded

Reason: PR #3415 proposed reading SNAPCRAFT_TARGET_ARCH in the CLI plus scrubbing it from provider flags, but was closed unmerged after review feedback. Merged PR #3414 (commit ff2cd96bb) delivered the same goal by setting SNAPCRAFT_TARGET_ARCH in the project loader's build environment.

Evaluated by: mr-cal-bot

No scores available.

Issue body

But ensure it is scrubbed from build provider flags so that it doesn't get passed into target environment. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged with changes requested. Superseded by merged PR #3414 (ff2cd96bb), which exported SNAPCRAFT_TARGET_ARCH in the project loader's build environment instead of adding a CLI envvar option.
stealth/space-bunny-alpha — closed stale Closed unmerged without a release change; merged PR #3414 instead exported SNAPCRAFT_TARGET_ARCH in the build environment (ff2cd96bb).
stealth/space-bunny-alpha — closed not a bug PR #3568 was closed unmerged after changes were requested; no support for SNAPCRAFT_TARGET_ARCH was released.
qwen/qwen3.6-35b-a3b — — Closed without merging after a reviewer requested changes with one unresolved comment. The proposed CLI environment variable matching was abandoned.
qwen3.6-35b-a3b-mtp-q6 — — Closed without merge, likely abandoned. The proposed change to align SNAPCRAFT_TARGET_ARCH with --target-arch and scrub it from build provider flags was not implemented.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#3414 (confidence 92%)

    Merged PR that exports SNAPCRAFT_TARGET_ARCH in the project loader (commit ff2cd96bb), delivering the intent of #3415.

  • Related To: canonical/snapcraft#3568 (confidence 70%)

    Later attempt with the same title to add a SNAPCRAFT_TARGET_ARCH envvar alternative to --target-arch; also closed unmerged.

  • Related To: canonical/snapcraft#3418 (confidence 55%)

    Follow-up (a05e64594) setting project target arch unconditionally so SNAPCRAFT_TARGET_ARCH is always populated.

Related issues

Issue Project State Summary Similarity
#3568 cli: enable SNAPCRAFT_TARGET_ARCH envvar matching --target-arch snapcraft closed Closed unmerged after maintainers rejected expanding environment-variable support for CLI options; SNAPCRAFT_TARGET_ARCH was not accepted as an alternative to --target-arch.
91%
#3414 project loader: export SNAPCRAFT_TARGET_ARCH in build environment snapcraft merged Merged PR #3414 (commit ff2cd96bb) added SNAPCRAFT_TARGET_ARCH to the global build environment in set_global_environment() for core22, alongside SNAPCRAFT_ARCH_TRIPLET.
81%
#3418 project: always set target arch even if not cross compiling snapcraft merged Merged PR #3418 in commit a05e64594, setting an explicit target architecture for native and cross builds and consistently defining SNAPCRAFT_TARGET_ARCH.
78%
#2179 cli: SNAPCRAFT_BUILD_ENVIRONMENT isn't deprecated snapcraft merged Merged PR #2179 (commit 1ff7550be) by kyrofa fixed the conflicting-env-vars error in the CLI, which wrongly named SNAPCRAFT_BUILD_ENVIRONMENT as deprecated; it now correctly names SNAPCRAFT_CONTAINER_BUILDS.
71%