extensions: add conditional for GNOME Makefile using bindtextdomain
Metadata
Current evaluation
Merged after approval, adding a Makefile conditional for bindtextdomain.so to support GNOME 3.28 and 3.34 extensions. Reviewer verified LD_PRELOAD safety. Changes modified 7 files (+49/-13 lines).
Suggested action: —
No scores available.
Issue body
Split the Makefile into smaller logical pieces and add a conditional
for bindtextdomain.so. Set bindtextdomain.so to build for GNOME 3.28
and 3.34 extensions.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval, adding a Makefile conditional for bindtextdomain.so to support GNOME 3.28 and 3.34 extensions. Reviewer verified LD_PRELOAD safety. Changes modified 7 files (+49/-13 lines). | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a Makefile update adding a conditional to build bindtextdomain.so only for GNOME 3.28 and 3.34 extensions. Approved after verifying safe LD_PRELOAD behavior, the changes were integrated to optimize extension builds. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Split the GNOME Makefile and added a conditional to build bindtextdomain.so only for GNOME 3.28 and 3.34 extensions. Review confirmed existence checks prevent unnecessary LD_PRELOAD attempts. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3178 extensions: add gcc to GNOME 3.28 extension part | snapcraft | merged | Merged changes adding gcc to the GNOME 3.28 extension part. Approved by one reviewer with passing CI checks. The minimal +2/-2 line diff across two files resolves Launchpad bug #1883392. |