← Back to issue list

Fix snap

View original Github issue

Metadata

Project
snapcraft
Number
#3445
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged as c63095654: pinned cryptography<3.5 in the snap build so Snapcraft snap builds no longer required a Rust toolchain. Tightened to 3.4 in #3447.

Resolution: closed resolved

Reason: PR #3445 merged into main as commit c63095654 ("snap: lock cryptography<3.5 to avoid rust"), pinning the dependency so the snap built without rustc. Follow-up PR #3447 (2ae657b4a) pinned exactly 3.4, and the local-setup gap raised in review was fixed by #3580 (33ec8aed4). The pin was later replaced by #4136 and rustup on risc-v (#4163).

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as c63095654: pinned cryptography<3.5 in the snap build so Snapcraft snap builds no longer required a Rust toolchain. Tightened to 3.4 in #3447.
stealth/space-bunny-alpha — closed resolved Merged as c63095654: pinned cryptography below 3.5 so building the Snapcraft snap no longer required a Rust toolchain.
qwen/qwen3.6-35b-a3b — — Merged by maintainer sergiusens after approval. The change updated snap build configuration, addressing Python and cryptography dependency adjustments for riscv and rust toolchain requirements.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for snap build failures related to Python version compatibility and cryptography/Rust dependencies. Updated bootstrap scripts and requirements to resolve riscv build issues.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#3447 (confidence 95%)

    Merged as 2ae657b4a, tightening the <3.5 constraint to an exact 3.4 pin to restore builds on all architectures including s390x.

  • Related To: snapcraft#3580 (confidence 90%)

    Merged as 33ec8aed4; resolved xnox's review comment that the local setup script and requirements.txt were not adjusted to match the pin.

  • Superseded By: snapcraft#4136 (confidence 80%)

    Merged as 3fd3e4c52, updating the cryptography dependency and making the old <3.5 pin unnecessary.

  • Superseded By: snapcraft#4163 (confidence 75%)

    Merged as 95e88a1c1, using rustup on risc-v as a temporary workaround until core22, superseding the no-rust approach.

Related issues

Issue Project State Summary Similarity
#3447 snap: pin cryptography to 3.4 snapcraft merged Merged as commit 2ae657b4a: pinned cryptography to ==3.4 in snap/snapcraft.yaml (+2/-2), tightening the earlier cryptography<3.5 lock from PR #3445 because 3.4.1 broke pip installs on s390x.
86%
#4033 build(deps): bump cryptography from 3.4 to 39.0.1 snapcraft closed Closed unmerged because cryptography 39.0.1 did not work on every architecture; maintainers cited canonical/charmcraft#1024, and Snapcraft later updated it in #4136 (3fd3e4c52).
75%
#1091 snap: ensure cryptography builds correctly on all architectures charmcraft merged Merged #1091 as 92e93b46, adding a temporary snap build workaround so cryptography compiles on all supported architectures.
71%