← Back to issue list

snap: pin cryptography to 3.4

View original Github issue

Metadata

Project
snapcraft
Number
#3447
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 2ae657b4a: pinned cryptography to ==3.4 in snap/snapcraft.yaml (+2/-2), tightening the earlier cryptography<3.5 lock from PR #3445 because 3.4.1 broke pip installs on s390x.

Resolution: closed resolved

Reason: PR #3447 was approved and merged into master as commit 2ae657b4a ("snap: pin cryptography to 3.4 (#3447)"), landing immediately after c63095654 (#3445). The pin was later revised by commit 3fd3e4c52 (#4136) and eventually dropped when requirements generation moved to uv.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Latest version that works with Snapcraft on all architectures with current requirements. E.g. on s390x with 3.4.1 it runs into an issue with pip: ``` Collecting PyYAML==5.3 Downloading PyYAML-5.3.tar.gz (268 kB) ERROR: Exception: Traceback (most recent call last): File "/build/snapcraft-snapcraft-b7d60c/parts/snapcraft/install/lib/python3.6/site-packages/pip/_vendor/resolvelib/resolvers.py", line 171, in _merge_into_criterion crit = self.state.criteria[name] KeyError: 'pyyaml' ``` Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 2ae657b4a: pinned cryptography to ==3.4 in snap/snapcraft.yaml (+2/-2), tightening the earlier cryptography<3.5 lock from PR #3445 because 3.4.1 broke pip installs on s390x.
stealth/space-bunny-alpha — closed resolved PR merged as commit 2ae657b4a ("snap: pin cryptography to 3.4"), pinning cryptography to 3.4 in snap/snapcraft.yaml so the Snapcraft snap builds on all arches (fixed s390x pip failure).
stealth/space-bunny-alpha — closed resolved Merged in #3447 (commit 2ae657b4a), pinning cryptography to 3.4 to restore Snapcraft builds across architectures, including s390x.
qwen/qwen3.6-35b-a3b — — Merged changes pinning cryptography to version 3.4, resolving a pip KeyError and build failure on s390x architecture during Snapcraft packaging. Approved and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged pinning cryptography to version 3.4 to resolve a pip resolution error on s390x during Snapcraft builds. Code coverage remains unchanged.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#3445 (confidence 95%)

    Merged just before as c63095654, adding cryptography<3.5 to avoid Rust; #3447 replaced that looser pin with ==3.4 after3.4.1 failed on s390x.

  • Superseded By: canonical/snapcraft#4136 (confidence 60%)

    Commit 3fd3e4c52 'deps: update cryptography dependency (#4136)' later un-pinned/updated cryptography, and 081a66d06 removed requirement pinning in favour of uv-generated requirements.

Related issues

Issue Project State Summary Similarity
#3445 Fix snap snapcraft merged Merged as c63095654: pinned cryptography<3.5 in the snap build so Snapcraft snap builds no longer required a Rust toolchain. Tightened to 3.4 in #3447.
86%
#4033 build(deps): bump cryptography from 3.4 to 39.0.1 snapcraft closed Closed unmerged because cryptography 39.0.1 did not work on every architecture; maintainers cited canonical/charmcraft#1024, and Snapcraft later updated it in #4136 (3fd3e4c52).
75%
#1091 snap: ensure cryptography builds correctly on all architectures charmcraft merged Merged #1091 as 92e93b46, adding a temporary snap build workaround so cryptography compiles on all supported architectures.
73%
#6163 build(deps): bump cryptography from 46.0.6 to 46.0.7 snapcraft merged Dependabot bump of cryptography 46.0.6→46.0.7 (CVE-2026-39892 buffer-overflow fix, OpenSSL 3.5.6 wheels) merged into snapcraft via PR #6163, commit a8123a0a8.
70%