repo: account for arch & version when filtering stage packages
Metadata
Current evaluation
Closed unmerged and superseded by #3461, merged as commit 0bf7a2e66 to remove architecture and version qualifiers from stage-package filters.
Resolution: closed superseded
Reason: The author closed this PR after noting it was replaced by #3461. PR #3461 merged to master as commit 0bf7a2e66 with the intended filtering fix and expanded tests.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The filter should only contain package names, not including the
optional [:arch] or [=version] fields.
Move the filter/no-filter logic out of apt_cache and introduce
a _get_filtered_stage_packages() helper in _deb to handle the
processing.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged and superseded by #3461, merged as commit 0bf7a2e66 to remove architecture and version qualifiers from stage-package filters. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged and replaced by #3461, which was merged into master to handle architecture and version qualifiers correctly when filtering stage packages. | |
| qwen/qwen3.6-35b-a3b | — | — | Superseded by PR #3461. Adjusts stage package filtering to account for architecture and version fields by moving the logic into a dedicated helper function. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Superseded by pull request #3461. Updates stage package filtering to exclude architecture and version fields, relocating the logic to a dedicated helper function. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#3461
(confidence 100%)
Merged replacement PR, recorded as commit 0bf7a2e66.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3461 repo: account for arch & version when filtering stage packages | snapcraft | merged | Merged in snapcraft#3461 via commit 0bf7a2e66, adding DebPackage-based filtering so architecture and version qualifiers are excluded from package-name filters. | |
| #3496 Revert "repo: account for arch & version when filtering stage packages (#3461)" | snapcraft | closed | Closed unmerged without explanation; its proposed rollback of #3461 (commit 0bf7a2e66) was not applied. | |
| #876 repo: allow for architecture-specific stage-packages | snapcraft | merged | Merged as 9d6f953a1 with package:arch support for stage-packages; the change was later reverted by #898 in 5ac55528f. | |
| #3080 repo: fix for multi-arch stage-package scenario | snapcraft | merged | Merged in commit 4a75be6ec, fixing multi-arch stage-package dependency resolution with architecture-aware package lookup. |