repo: account for arch & version when filtering stage packages
Metadata
Current evaluation
Superseded by PR #3461. Adjusts stage package filtering to account for architecture and version fields by moving the logic into a dedicated helper function.
Suggested action: —
No scores available.
Issue body
The filter should only contain package names, not including the
optional [:arch] or [=version] fields.
Move the filter/no-filter logic out of apt_cache and introduce
a _get_filtered_stage_packages() helper in _deb to handle the
processing.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Superseded by PR #3461. Adjusts stage package filtering to account for architecture and version fields by moving the logic into a dedicated helper function. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Superseded by pull request #3461. Updates stage package filtering to exclude architecture and version fields, relocating the logic to a dedicated helper function. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Superseded by pull request #3461. The author closed this to incorporate improved testing and finalize the stage package filtering logic in the replacement. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3461 repo: account for arch & version when filtering stage packages | snapcraft | merged | Merged into master. Refactored stage package filtering to correctly handle architecture and version qualifiers via a new helper. Updated cross-compile tests, achieved 90.74% diff coverage, and passed CI after maintainer approval. | |
| #3496 Revert "repo: account for arch & version when filtering stage packages (#3461)" | snapcraft | closed | Closed to revert commit 0bf7a2e6619b0037a50caeb49d28788c021d0921, undoing architecture and version filtering for stage packages. | |
| #876 repo: allow for architecture-specific stage-packages | snapcraft | merged | Merged. Implements architecture-specific stage-packages using a package:arch syntax in the stage-packages list. A per-part architecture approach was rejected during review. The updated code passed CI and was merged. |