repo: account for arch & version when filtering stage packages
Metadata
Current evaluation
Merged in snapcraft#3461 via commit 0bf7a2e66, adding DebPackage-based filtering so architecture and version qualifiers are excluded from package-name filters.
Resolution: closed resolved
Reason: PR #3461 merged as commit 0bf7a2e66. It introduced _get_filtered_stage_packages(), standardized parsing with DebPackage, and expanded cross-compile test coverage.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The filter should only contain package names, not including the
optional [:arch] or [=version] fields.
(1) Move the filter/no-filter logic out of apt_cache and introduce
a _get_filtered_stage_packages() helper in _deb to handle the
processing. Use newly introduced DebPackage to ensure consistency,
and do the same for get_packages_in_base().
(2) Update cross-compile spread test to incorporate the various
grammars.
Depends on #3460
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcraft#3461 via commit 0bf7a2e66, adding DebPackage-based filtering so architecture and version qualifiers are excluded from package-name filters. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in PR #3461 (commit 0bf7a2e66), moving stage-package filtering to a DebPackage-based helper so filters contain names without architecture or version qualifiers; cross-compile tests were updated. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. Refactored stage package filtering to correctly handle architecture and version qualifiers via a new helper. Updated cross-compile tests, achieved 90.74% diff coverage, and passed CI after maintainer approval. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Refactored stage package filtering to correctly handle architecture and version specifiers using a new helper and DebPackage. Updated cross-compile spread tests to cover various grammars. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#3460
(confidence 99%)
Dependency that introduced DebPackage and standardized Debian package-name parsing.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3459 repo: account for arch & version when filtering stage packages | snapcraft | closed | Closed unmerged and superseded by #3461, merged as commit 0bf7a2e66 to remove architecture and version qualifiers from stage-package filters. | |
| #1655797 Set arch for stage packages | snapcraft (launchpad) | closed | Fixed architecture qualifiers such as i386 in stage packages via snapcore/snapcraft PR #1050. | |
| #876 repo: allow for architecture-specific stage-packages | snapcraft | merged | Merged as 9d6f953a1 with package:arch support for stage-packages; the change was later reverted by #898 in 5ac55528f. | |
| #3080 repo: fix for multi-arch stage-package scenario | snapcraft | merged | Merged in commit 4a75be6ec, fixing multi-arch stage-package dependency resolution with architecture-aware package lookup. |