cli & providers: pass part names for lifecycle commands (CRAFT-481)
Metadata
Current evaluation
Merged after resolving initial test and mypy failures. Passes part names to managed snapcraft for lifecycle commands and fixes a type annotation. Approved by two reviewers with 100% diff coverage.
Suggested action: —
No scores available.
Issue body
Executing lifecycle commands with part names will result
in the parts being dropped when executing snapcraft in the
provided environment.
- Pass these part names along to managed snapcraft.
- Fix type annotation for 'parts' in lifecycle's execute().
LP: #1897337
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after resolving initial test and mypy failures. Passes part names to managed snapcraft for lifecycle commands and fixes a type annotation. Approved by two reviewers with 100% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Successfully merged PR #3572 to pass part names to managed snapcraft during lifecycle commands and fix a type annotation. After resolving test and mypy failures, the changes achieved 100% coverage and were integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to fix lifecycle commands dropping parts by passing part names to managed snapcraft and correcting type annotations. Resolved test and mypy failures prior to integration, implementing CRAFT-481 and LP #1897337. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #228 packages: run snap operations silently | craft-parts | merged | Merged to fix #218 by running snap subprocesses silently, preventing stdout leakage that conflicts with craft-cli during lifecycle execution. Approved by one reviewer, passed CI, and modified two files (+32/-15 lines). | |
| #3630 cli: add lifecycle command stubs (CRAFT-764) | snapcraft | merged | Merged into snapcraft/7.0. Added CLI stubs for pull, build, stage, and prime phases, falling back to legacy. Reorganized CLI tests and fixed version command tests. Approved and passed CI. |