cli & providers: pass part names for lifecycle commands (CRAFT-481)
Metadata
Current evaluation
PR #3572 merged as f0e722b17 (commit b1ae32a69), fixing lifecycle commands to forward part names to managed Snapcraft in build environments and correcting the 'parts' type annotation in lifecycle execute(). Closes LP #1897337 (CRAFT-481).
Resolution: closed resolved
Reason: Merged into master as commit f0e722b17 ('Merge pull request #3572 from cjp256/fix-lifecycle-parts'), with the change commit b1ae32a69 'cli & providers: pass part names for lifecycle commands'. The PR passed review (cmatsuoka, kyrofa, sergiusens) after follow-up mypy/unit test fixes landed in the branch.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Executing lifecycle commands with part names will result
in the parts being dropped when executing snapcraft in the
provided environment.
- Pass these part names along to managed snapcraft.
- Fix type annotation for 'parts' in lifecycle's execute().
LP: #1897337
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #3572 merged as f0e722b17 (commit b1ae32a69), fixing lifecycle commands to forward part names to managed Snapcraft in build environments and correcting the 'parts' type annotation in lifecycle execute(). Closes LP #1897337 (CRAFT-481). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcore/snapcraft#3572 (f0e722b17), fixing lifecycle commands to forward part names to managed Snapcraft and correcting the parts type annotation. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcore/snapcraft#3572 via f0e722b17: lifecycle commands now pass part names into managed builds, preventing parts from being dropped. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after resolving initial test and mypy failures. Passes part names to managed snapcraft for lifecycle commands and fixes a type annotation. Approved by two reviewers with 100% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Successfully merged PR #3572 to pass part names to managed snapcraft during lifecycle commands and fix a type annotation. After resolving test and mypy failures, the changes achieved 100% coverage and were integrated. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcore/snapcraft#4092
(confidence 45%)
Later PR touching cli lifecycle checking (experimental plugins), same subsystem area.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3660 providers: integrate craft-providers support | snapcraft | merged | PR #3660 by cmatsuoka integrated craft-providers into Snapcraft, running lifecycle commands in LXD/Multipass instances. Merged into the 7.0 line via merge commit 7c2ac0027 (squash commit 8a06cdbbd). | |
| #2442 cli: enable cleaning of parts | snapcraft | merged | Merged #2442 (5546c3aab), restoring snapcraft clean <part-name> with build providers so selected parts can be cleaned without recreating the provider. |