← Back to issue list

snaps: eliminate extra call to query snap info (CRAFT-479)

View original Github issue

Metadata

Project
snapcraft
Number
#3573
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged #3573 (commit 4c63e5937; merge 2a2342c69), reusing the initial snap-info response to avoid duplicate snapd/Snap Store queries.

Resolution: closed resolved

Reason: The approved PR was merged into master as 2a2342c69. Its implementation commit 4c63e5937 eliminates the redundant snap-info request.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Re-use first response to prevent Snapcraft from asking snapd to reach out to the Snap Store twice in a row for the same data. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #3573 (commit 4c63e5937; merge 2a2342c69), reusing the initial snap-info response to avoid duplicate snapd/Snap Store queries.
stealth/space-bunny-alpha — closed resolved Merged #3573 via 2a2342c69, reusing the first snap-info response to prevent duplicate snapd requests to the Snap Store.
stealth/space-bunny-alpha — closed resolved Merged PR #3573 as 2a2342c69, reusing the initial snap-info response to avoid duplicate consecutive snapd/Snap Store queries.
stealth/space-bunny-alpha — closed resolved Merged PR #3573, reusing the first snap info response to avoid duplicate snapd queries to the Snap Store.
qwen/qwen3.6-35b-a3b — — Merged optimization reusing the initial snap info response to eliminate duplicate snapd queries. Approved by one reviewer, passed CI, and achieved 100% diff coverage with a three-line change.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Optimizes snap info retrieval by reusing the initial response, eliminating redundant snapd calls to the Snap Store. Achieved 100% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5689 fix: remove unnecessary snapd_snap flag (#5316) snapcraft merged Merged #5689 as 8f02d3d48, removing the unnecessary snapd_snap flag and fixing #5316; the change was also backported in #5694.
70%