fix: remove unnecessary snapd_snap flag (#5316)
Metadata
Current evaluation
PR #5316 merged, removing the unnecessary snapd_snap flag across two files and deleting 14 lines. The change received three approvals, passed all CI checks, and was successfully integrated.
Suggested action: —
No scores available.
Issue body
- [ ] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `make test`?
---
Discussing with @mr-cal we decided this could safely be removed.
[SNAPCRAFT-1193](https://warthogs.atlassian.net/browse/SNAPCRAFT-1193)
[SNAPCRAFT-1193]: https://warthogs.atlassian.net/browse/SNAPCRAFT-1193?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | PR #5316 merged, removing the unnecessary snapd_snap flag across two files and deleting 14 lines. The change received three approvals, passed all CI checks, and was successfully integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Pull request #5316 merged, removing the unnecessary snapd_snap flag per SNAPCRAFT-1193. Approved after review with @mr-cal. Code passes lint and test suites. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged #5316 removes the unnecessary snapd_snap flag per SNAPCRAFT-1193. Approved after discussion with @mr-cal, the change passed all lint and test checks before integration. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5694 fix(backport): remove unnecessary snapd_snap flag (#5689) | snapcraft | merged | Merged PR #5689 backports a fix for issue #5316 to Snapcraft 7.5. The change removes an unnecessary snapd_snap flag across two files. All CI checks passed and the pull request was approved before merging. | |
| #1051 misc: remove snapd "submodule" | snapcraft | merged | Merged changes removing the snapd submodule reference. The update deleted one line in a single file, received one approval, and integrated into master without affecting code coverage. | |
| #1569 tests: refactor the fake snapd to not hardcode values | snapcraft | merged | Merged PR refactoring fake snapd tests to remove hardcoded values. Approved by two reviewers, CI passed. Six files changed with 238 additions and 126 deletions. Requires PR #1567. | |
| #911 Remove the outdated all snaps image set up for snaps tests | snapcraft | merged | Merged removal of the outdated all snaps image setup for snaps tests. Approved by one reviewer, modifying two files with a net reduction of 33 lines. References Launchpad bug #1642410. | |
| #3505 snaps: don't validate snaps before `SnapPackage.download()` | snapcraft | merged | Merged a fix that skips snap validation before SnapPackage.download(), resolving branch staging issues (LP#1901733). Approved by two reviewers, passed CI, and changed three files (+16/-11 lines). | |
| #544 fix(i/snap): don't reject non-snap squashfs files | fetch-service | merged | Merged a fix to the snap inspector that ignores non-snap squashfs files instead of rejecting them. Approved by two reviewers, passed all CI checks, and applied with 16 additions and 4 deletions across two files. | |
| #228 packages: run snap operations silently | craft-parts | merged | Merged to fix #218 by running snap subprocesses silently, preventing stdout leakage that conflicts with craft-cli during lifecycle execution. Approved by one reviewer, passed CI, and modified two files (+32/-15 lines). | |
| #2507 build providers: improve handling in snap logic | snapcraft | merged | Merged. Improved snap provider logic by cleaning up channel warnings, removing unnecessary sudo calls, and silencing noisy refresh hold commands. Approved, passed CI, and modified 5 files (+131/-73 lines). | |
| #3573 snaps: eliminate extra call to query snap info (CRAFT-479) | snapcraft | merged | Merged optimization reusing the initial snap info response to eliminate duplicate snapd queries. Approved by one reviewer, passed CI, and achieved 100% diff coverage with a three-line change. | |
| #5188 fix: improve error message from snapd pack | snapcraft | merged | Merged fix improving snapd pack error messages, resolving issue #4499. Approved by three reviewers, the update modifies seven files with 122 additions and 9 deletions to enhance error reporting. |