fix: remove unnecessary snapd_snap flag (#5316)
Metadata
Current evaluation
Merged #5689 as 8f02d3d48, removing the unnecessary snapd_snap flag and fixing #5316; the change was also backported in #5694.
Resolution: closed resolved
Reason: PR #5689 merged as commit 8f02d3d48, deleting obsolete snapd_snap handling after review and all CI checks passed. Backport PR #5694 later merged the fix as cb5283b6a for Snapcraft 7.5.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `make test`?
---
Discussing with @mr-cal we decided this could safely be removed.
[SNAPCRAFT-1193](https://warthogs.atlassian.net/browse/SNAPCRAFT-1193)
[SNAPCRAFT-1193]: https://warthogs.atlassian.net/browse/SNAPCRAFT-1193?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #5689 as 8f02d3d48, removing the unnecessary snapd_snap flag and fixing #5316; the change was also backported in #5694. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #5689 (commit 8f02d3d48, tracked as SNAPCRAFT-1193) merged to drop the obsolete snapd_snap flag causing the core20 repack error in #5316; backported for 7.5 via merged PR #5694 (cb5283b6a). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #5316 removed the unnecessary snapd_snap flag for SNAPCRAFT-1193, deleting 14 lines across two files after three approvals and a clean CI run. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #5689 for #5316 removed the obsolete snapd_snap flag; backport PR #5694 was also merged. | |
| qwen/qwen3.6-35b-a3b | — | — | PR #5316 merged, removing the unnecessary snapd_snap flag across two files and deleting 14 lines. The change received three approvals, passed all CI checks, and was successfully integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Pull request #5316 merged, removing the unnecessary snapd_snap flag per SNAPCRAFT-1193. Approved after review with @mr-cal. Code passes lint and test suites. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#5694
(confidence 100%)
Backported the #5689 fix for Snapcraft 7.5 in commit cb5283b6a.
-
Likely Fixed By:
canonical/snapcraft#5316
(confidence 99%)
The snapd_snap removal in #5689 fixed the core20 repacking failure tracked by #5316.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5694 fix(backport): remove unnecessary snapd_snap flag (#5689) | snapcraft | merged | Merged backport #5694 (cb5283b6a) removed obsolete snapd_snap handling for Snapcraft 7.5, fixing core20 repacking failure #5316; original fix was #5689. | |
| #1051 misc: remove snapd "submodule" | snapcraft | merged | Merged PR #1051 as commit f62ac0ce1, removing the obsolete snapd testing-tools submodule reference in a one-line cleanup. | |
| #3573 snaps: eliminate extra call to query snap info (CRAFT-479) | snapcraft | merged | Merged #3573 (commit 4c63e5937; merge 2a2342c69), reusing the initial snap-info response to avoid duplicate snapd/Snap Store queries. |