sources: make submodule recursion configurable
Metadata
Current evaluation
PR #3623 adding source-recurse-submodules was closed as superseded by #3629, which added source-submodules (list/empty/all) and was merged in 383c1f1ce.
Resolution: closed superseded
Reason: Reviewers pushed for per-submodule selection instead of a boolean; author opened snapcore/snapcraft#3629 ("sources: make submodule fetching configurable"), which merged as 383c1f1ce and backported via 4fabb9a1d. Maintainer cmatsuoka closed #3623 with "Superseded by PR #3629".
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `./runtests.sh static`?
- [X] Have you successfully run `./runtests.sh tests/unit`?
-----
https://bugs.launchpad.net/snapcraft/+bug/1957767
Add new parameter `source_recurse_submodules`
Example snapcraft.yaml:
```
parts:
git:
source: https://github.com/snapcore/snapcraft
source-type: git
source-commit: "HEAD"
source-recurse-submodules: False
```
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | PR #3623 adding source-recurse-submodules was closed as superseded by #3629, which added source-submodules (list/empty/all) and was merged in 383c1f1ce. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed as superseded by merged PR #3629, which replaced source-recurse-submodules with source-submodules for selecting specific git submodules, fetching none, or fetching all by default. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged after reviewer feedback; PR #3629 replaced the boolean option with list-based source-submodules control and was merged. | |
| qwen/qwen3.6-35b-a3b | — | — | Superseded by PR #3629. The original boolean recursion flag was replaced with a list-based approach for selecting specific submodules, addressing reviewer feedback for broader functionality and practical implementation. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Superseded by PR #3629. The initial boolean toggle for submodule recursion was replaced with a more flexible approach allowing specific submodule selection. A new PR was opened to implement the expanded functionality, closing this one. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
snapcore/snapcraft#3629
(confidence 99%)
Successor PR merged in commit 383c1f1ce implementing source-submodules
-
Related To:
snapcraft#3635
(confidence 70%)
Backport merge commit 4fabb9a1d of the 7.0 branch of the same change
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3629 sources: make submodule fetching configurable | snapcraft | merged | Merged #3629 via 383c1f1ce, adding source-submodules to select specific Git submodules, fetch none with [], or fetch all by default. |