sources: make submodule fetching configurable
Metadata
Current evaluation
Merged into snapcraft/7.0 as 4fabb9a1d, backporting #3629 to add configurable Git submodule fetching through source-submodules.
Resolution: closed resolved
Reason: PR #3635 was merged into snapcraft/7.0 by merge commit 4fabb9a1d, with implementation commit ac02c36ec. It backports #3629 and adds source-submodules controls to select, skip, or fetch all Git submodules.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `./runtests.sh static`?
- [X] Have you successfully run `./runtests.sh tests/unit`?
-----
Duplicate of https://github.com/snapcore/snapcraft/pull/3629, but applied to `snapcraft/7.0`.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged into snapcraft/7.0 as 4fabb9a1d, backporting #3629 to add configurable Git submodule fetching through source-submodules. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into snapcraft/7.0 as 4fabb9a1d (implementation ac02c36ec), backporting #3629 to make Git submodule fetching configurable. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into snapcraft/7.0 via 4fabb9a1d (ac02c36ec), making Git submodule fetching configurable and backporting merged PR #3629. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into snapcraft/7.0 (4fabb9a1d) as a backport of #3629, adding the source-submodules option to choose, skip ([]), or fetch all git submodules. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged to snapcraft/7.0 (merge commit 4fabb9a1d, fix commit ac02c36ec), backporting #3629: adds a source-submodules key so Git submodule fetching is configurable instead of always fetching all. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3635 into snapcraft/7.0 (4fabb9a1d), backporting #3629. Added source-submodules configuration to choose, skip, or fetch all git submodules. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into snapcraft/7.0 as a backport of #3629, making Git submodule fetching configurable (merge commit 4fabb9a1d). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into the snapcraft/7.0 branch as a backport of PR #3629. The update makes submodule fetching configurable, passed review and CI, and was integrated without impacting coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into the snapcraft/7.0 branch, enabling configurable submodule fetching. This change backports PR #3629 to the 7.0 release line. Code coverage remained unchanged upon integration. |
Update history
No update history recorded yet.
Related work
-
Duplicate Of:
snapcore/snapcraft#3629
(confidence 100%)
The PR description explicitly identifies #3629 as the original and #3635 as its snapcraft/7.0 backport.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3629 sources: make submodule fetching configurable | snapcraft | merged | Merged #3629 via 383c1f1ce, adding source-submodules to select specific Git submodules, fetch none with [], or fetch all by default. | |
| #169 sources: make submodule fetching configurable | craft-parts | merged | Merged craft-parts#169 via commit 3891f255, adding configurable Git submodule fetching, including selected submodules, disabling them with an empty list, or fetching all by default. | |
| #249 Git source: Support submodules. | snapcraft | merged | Merged canonical/snapcraft#249 via 1984cb339, adding recursive Git cloning and submodule updates on pull to resolve LP #1536698. | |
| #1640675 Add source option for git submodules | snapcraft (launchpad) | closed | Feature request implemented: source-submodules added to git sources, merged as snapcraft PR #3629 (383c1f1ce) and craft-parts PR #169 (3891f255); shipped in Snapcraft 7 and 8. Maintainer closed the2016 Launchpad bug as done. | |
| #1957767 no way to use non-recursive git source | snapcraft (launchpad) | closed | Merged in snapcore/snapcraft#3629, adding configurable Git submodule fetching so non-recursive clones can be requested. | |
| #1536698 Git source doesn't support submodules | snapcraft (launchpad) | closed | Git source submodule support was implemented and merged in ubuntu-core/snapcraft PR #249 (merge commit 1984cb339), using recursive cloning and submodule updates on pull. |