← Back to issue list

Git source: Support submodules.

View original Github issue

Metadata

Project
snapcraft
Number
#249
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged canonical/snapcraft#249 via 1984cb339, adding recursive Git cloning and submodule updates on pull to resolve LP #1536698.

Resolution: closed resolved

Reason: PR #249 was merged with implementation commit 3ff0d4001 and merge commit 1984cb339, adding Git submodule support.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR resolves LP: [#1536698](https://bugs.launchpad.net/snapcraft/+bug/1536698) by cloning recursively (thus retrieving submodules), and updates them when pulled as well.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged canonical/snapcraft#249 via 1984cb339, adding recursive Git cloning and submodule updates on pull to resolve LP #1536698.
stealth/space-bunny-alpha — closed resolved Merged PR #249 in commit 1984cb339, adding recursive Git cloning and submodule updates on pull to resolve LP #1536698.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#249 (1984cb339), adding recursive Git cloning and submodule updates on pull to resolve LP #1536698.
qwen/qwen3.6-35b-a3b — — Merged implementation adding recursive git cloning to support submodules, resolving Launchpad bug #1536698. Submodules update on pull. Changes affect two files. Merged despite reviewer requests for integration tests.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Adds recursive cloning and updating for Git submodules, resolving LP #1536698. Implementation accepted after reviewer requested an integration test.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1536698 Git source doesn't support submodules snapcraft (launchpad) closed Git source submodule support was implemented and merged in ubuntu-core/snapcraft PR #249 (merge commit 1984cb339), using recursive cloning and submodule updates on pull.
86%
#1640675 Add source option for git submodules snapcraft (launchpad) closed Feature request implemented: source-submodules added to git sources, merged as snapcraft PR #3629 (383c1f1ce) and craft-parts PR #169 (3891f255); shipped in Snapcraft 7 and 8. Maintainer closed the2016 Launchpad bug as done.
78%
#1957767 no way to use non-recursive git source snapcraft (launchpad) closed Merged in snapcore/snapcraft#3629, adding configurable Git submodule fetching so non-recursive clones can be requested.
76%
#3635 sources: make submodule fetching configurable snapcraft merged Merged into snapcraft/7.0 as 4fabb9a1d, backporting #3629 to add configurable Git submodule fetching through source-submodules.
76%
#1536696 Git source clones all history snapcraft (launchpad) closed Fixed by merged PR canonical/snapcraft#248 (commit 6ebd8e68d, merge 321b13277): Git sources now use a depth-1 shallow clone instead of fetching full history. Maintainer kyrofa linked the PR as the fix for LP #1536696.
74%
#898 Git source should check out a commit before recursing submodules craft-parts closed Fixed in craft-parts PR #1600 (commit d2845976): Git sources now check out the requested commit before running the recursive submodule update, instead of fetching submodules at the default branch first.
72%
#567 Add Subversion support snapcraft merged Merged Subversion source support, tests, and packaging updates in canonical/snapcraft#567 (commit 0e1ec16e6), fixing Launchpad bug 1543243 and shipping in Snapcraft 2.12.
72%
#1694765 source-type: git uses --remote for submodules snapcraft (launchpad) closed Fixed by merged PR snapcore/snapcraft#1344 (commit a8500f718), removing --remote from Git submodule updates so superproject-recorded revisions are honored.
72%
#248 Git source: Make a shallow clone. snapcraft merged Merged #248 (commit 6ebd8e68d; merge 321b13277), changing Git sources from full clones to depth-1 shallow clones and resolving LP #1536696.
71%
#1137 Build-depend on git snapcraft merged Merged in canonical/snapcraft#1137 (commit 8b3cb387d), adding git as a direct build dependency so Git source tests can invoke git.
70%