← Back to issue list

linters: address issues and enable pylint in ci

View original Github issue

Metadata

Project
snapcraft
Number
#3672
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged linter fixes and enabled pylint in CI via PR #3672, merged as commit 32b26cb3e into the 7.0 branch.

Resolution: closed resolved

Reason: PR #3672 was approved and merged as commit 32b26cb3e. It addressed existing linter findings and enabled pylint in continuous integration.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged linter fixes and enabled pylint in CI via PR #3672, merged as commit 32b26cb3e into the 7.0 branch.
stealth/space-bunny-alpha — closed resolved Merged PR #3672 addressed linter issues and enabled pylint in CI; merged as commit 32b26cb3e.
qwen/qwen3.6-35b-a3b — — Merged after approval and CI pass. The PR addressed linter issues and enabled pylint in CI across 8 files. Changes increased test coverage by 0.02% with 100% diff coverage, successfully integrating static analysis into the pipeline.
qwen3.6-35b-a3b-mtp-q6 — — Merged Claudio Matsuoka's changes addressing linter issues and enabling pylint in CI. Integrated into the snapcraft/7.0 branch, increasing code coverage by 0.02% with 100% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#166 linters: re-enable pylint fixme info craft-parts merged Merged PR #166 in commit 86dc5757, re-enabling pylint's fixme-info reporting after maintainer approval.
75%
#567 ci: fix linter issues craft-parts merged PR #567 merged as c41f86d6, fixing CI linter issues across four files after approval.
73%
#494 lint: Set a linter conf and fix errors fetch-service merged Merged PR #494 as commit 338bcaf, adding golangci-lint configuration and fixing lint errors across 117 files; all CI checks passed.
72%
#66 lint: update pylint configuration craft-store merged Merged PR #66 as commit 20c7aa9, refreshing the pylint configuration without functional code changes.
71%
#29 tests: address pylint issues craft-parts merged Merged: small test-only cleanup of Pylint warnings (3 files, +7/-4) by maintainer cmatsuoka. Landed as commit 0a3d2554 via merge commit efb9bcc3 (PR #29).
70%