← Back to issue list

tests: address pylint issues

View original Github issue

Metadata

Project
craft-parts
Number
#29
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged: small test-only cleanup of Pylint warnings (3 files, +7/-4) by maintainer cmatsuoka. Landed as commit 0a3d2554 via merge commit efb9bcc3 (PR #29).

Resolution: closed resolved

Reason: PR #29 was approved by 3 reviewers and merged into main as commit efb9bcc3 ('Merge pull request #29 from cmatsuoka/fix/address-pylint-warnings-1'), carrying standalone commit 0a3d2554 'tests: address pylint issues' that silenced the reported Pylint warnings in the test suite.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Minor changes to address pylint warnings in tests. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged: small test-only cleanup of Pylint warnings (3 files, +7/-4) by maintainer cmatsuoka. Landed as commit 0a3d2554 via merge commit efb9bcc3 (PR #29).
stealth/space-bunny-alpha — closed resolved Merged #29 via efb9bcc3, applying test-only cleanup for Pylint warnings across 3 files (+7/-4).
stealth/space-bunny-alpha — closed resolved Merged test-only cleanup addressing Pylint warnings, changing 3 files (+7/-4).
qwen/qwen3.6-35b-a3b — — Merged to address pylint warnings in test files. Approved by three reviewers and passed CI. The update modified three files, adding seven and removing four lines.
qwen3.6-35b-a3b-mtp-q6 — — Merged minor updates to resolve pylint warnings in the test suite. The changes were reviewed and integrated into the main branch by maintainer Claudio Matsuoka.

Update history

No update history recorded yet.

Related work

  • Related To: craft-parts#22 (confidence 40%)

    Later lint configuration work (ruff/linter config, e.g. commit f3d35a68) continues the same linting cleanup effort started by this PR.

Related issues

Issue Project State Summary Similarity
#57 tests: update pylint and address new warnings craft-parts merged Merged PR #57 in commit 78560246 upgraded pylint to 2.8.2 and addressed the resulting warnings with minor test changes.
81%
#11 tests: configure pylint to issue fixme-info craft-parts merged Merged #11 via commit 08b51a7c, configuring pylint-fixme-info to report TODO/FIXME messages as informational and removing pylint's --fail-under CI check.
74%
#3813 lint: bump pylint snapcraft merged Merged in commit 522b301a9: updated Pylint and removed a redundant too-many-lines suppression across three files.
72%
#3672 linters: address issues and enable pylint in ci snapcraft merged Merged linter fixes and enabled pylint in CI via PR #3672, merged as commit 32b26cb3e into the 7.0 branch.
70%