← Back to issue list

tests: address pylint issues

View original Github issue

Metadata

Project
craft-parts
Number
#29
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged to address pylint warnings in test files. Approved by three reviewers and passed CI. The update modified three files, adding seven and removing four lines.

Suggested action:

No scores available.

Issue body

Minor changes to address pylint warnings in tests. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to address pylint warnings in test files. Approved by three reviewers and passed CI. The update modified three files, adding seven and removing four lines.
qwen3.6-35b-a3b-mtp-q6 Merged minor updates to resolve pylint warnings in the test suite. The changes were reviewed and integrated into the main branch by maintainer Claudio Matsuoka.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#57 tests: update pylint and address new warnings craft-parts merged Merged after two approvals and passing CI. Updated pylint to 2.8.2 and resolved newly introduced linting warnings in the test suite with minor code adjustments across a single file.
83%
#90 many: address new linter warnings (CRAFT-364) craft-parts merged Merged after resolving new linter warnings from updated mypy and pylint versions, including silencing checks in tests. Approved by two reviewers, passed CI, and modified eight files (+32/-22 lines).
78%
#461 test: improve test coverage fetch-service merged Merged to improve test coverage, adding 270 lines across three files. Approved by two reviewers with all CI checks passing.
76%
#4848 style: remove pylint comments snapcraft merged Merged cleanup removing remaining pylint comments. Approved by two reviewers, passed CI checks, and updated two files with minimal changes.
76%
#11 tests: configure pylint to issue fixme-info craft-parts merged Merged. Configured pylint to treat TODO and FIXME messages as informational instead of warnings or errors, removing the --fail-under CI flag. Approved by two reviewers and passed all checks.
74%
#118 style: remove pylint craft-store merged Merged to remove pylint from the project. Approved by one reviewer, passed CI checks, and modified two files with a net reduction of three lines.
74%
#458 test: improve test coverage fetch-service merged Merged after approval from two reviewers and passing CI checks. Added 370 lines of test code across five files to improve overall test coverage.
74%
#66 lint: update pylint configuration craft-store merged Merged an update to the pylint configuration, removing 627 lines of outdated settings and adding 16 lines with no functional changes. Approved by a reviewer and passed all CI checks.
74%
#4485 style(lint): fix pyright errors snapcraft merged Merged after approval by three reviewers. Resolved pyright linting errors across nine files (+59/-38 lines). Codecov confirmed test coverage remained stable at 89.2%.
73%
#2807 meta: address errors from mypy uprev snapcraft merged Merged following two reviewer approvals and passing CI. Resolves mypy type-checking errors from a version upgrade. Changes are mostly non-runtime affecting, with minor improvements to edge-case handling across six files.
73%