← Back to issue list

spread: remove git logic from pbr test

View original Github issue

Metadata

Project
snapcraft
Number
#3688
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #3688 via commit 3f2329ffd, removing unnecessary Git setup from the pbr spread test to prevent repository initialization errors.

Resolution: closed resolved

Reason: The change was merged into snapcraft/7.0 by merge commit 3f2329ffd, with the fix committed as eea6b4a82.

Evaluated by: mr-cal-bot

No scores available.

Issue body

It adds no value to the test itself and it now produces a git initialization error. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #3688 via commit 3f2329ffd, removing unnecessary Git setup from the pbr spread test to prevent repository initialization errors.
stealth/space-bunny-alpha — closed resolved Merged PR #3688 removed unnecessary Git setup from the pbr spread test, fixing a Git initialization error.
stealth/space-bunny-alpha — closed resolved Merged PR #3688 (commit 3f2329ffd), removing unnecessary Git initialization from the spread pbr test to prevent initialization errors without changing test coverage.
stealth/space-bunny-alpha — closed resolved Merged #3688 (e2e4fec) to remove unnecessary Git initialization from the pbr spread test, resolving a Git initialization error without changing coverage.
qwen/qwen3.6-35b-a3b — — Merged removal of unnecessary git initialization logic from the pbr test. Resolves a git initialization error, passed CI, received approval, and caused no coverage change.
qwen3.6-35b-a3b-mtp-q6 — — Merged removal of unnecessary git logic from the pbr test to resolve a git initialization error. The change was accepted with no impact on code coverage.

Update history

No update history recorded yet.

Related work

  • Related To: snapcore/snapcraft#3724 (confidence 85%)

    Later merged PR #3724 contains a matching change in commit f16ebe79d.

Related issues

Issue Project State Summary Similarity
#3724 spread: remove git user config from pbr test snapcraft merged Merged PR #3724 removed global Git user setup from the pbr spread test, relying on Git author/email environment variables.
86%
#2216 spread tests: keep sources local snapcraft merged Merged PR #2216 as commit c3bf480, replacing remote FTP sources in spread tests with in-tree tar archives to avoid failures caused by server outages.
70%