← Back to issue list

spread tests: keep sources local

View original Github issue

Metadata

Project
snapcraft
Number
#2216
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged PR #2216 to replace remote FTP sources in spread tests with in-tree tar archives, preventing test failures from server downtime. Approved by one reviewer, passed CI checks, and slightly increased code coverage.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- We've been having a few issues with FTP servers going down that we're using in spread tests. Stop using remote sources in spread tests, opting instead to carry tar archives of the sources in-tree.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged PR #2216 to replace remote FTP sources in spread tests with in-tree tar archives, preventing test failures from server downtime. Approved by one reviewer, passed CI checks, and slightly increased code coverage.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Replaced remote FTP sources in spread tests with in-tree tar archives to prevent test failures from server outages. Code coverage increased by less than 0.01%.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Replaced remote FTP sources in spread tests with in-tree tar archives to prevent test failures from server outages, improving test reliability.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3662 tests: update spread url snapcraft merged Merged update to spread tarball URLs in test files. Approved by a reviewer, passed CI checks, modified two files with minimal changes, and maintained existing code coverage.
81%
#3663 tests: update spread url snapcraft merged Merged following reviewer approval and passing CI. Updated spread tarball URLs in test configuration files, modifying two files with minimal changes.
78%
#4433 tests(spread): add remote-build spread test snapcraft merged Merged changes adding spread tests for new and legacy remote-build, resolving issue #4398. Approved by two reviewers with passing CI checks.
77%
#950 tests: Use a more stable ftp source snapcraft merged Merged into master after reviewer approval and passing code coverage checks. Updates test configuration to use a more stable FTP source, resolving LP: #1647751 with a minimal two-line change.
76%
#3020 spread tests: default base for local plugin tests snapcraft merged Merged updates to spread tests establishing a default base for local plugin tests. The change follows a prior commit pattern, adding two lines across two files. Approved by one reviewer and passed CI checks.
75%
#62 spread: add a "big" spread test rockcraft merged Merged a reusable spread test framework to house multiple checks without repeated setup. The initial test validates bug #44 regarding directory permissions. Approved by one reviewer and passed CI checks.
75%
#1290 test(spread): clean up store tests charmcraft merged Merged cleanup of spread store tests, removing 28 lines across four files. The underlying library test failure is fixed in PR #1292. Approved by two reviewers.
75%
#13 test(spread): add more spread tests snapcraft-rocks merged Successfully merged spread tests covering architectures, chisel slices, craftctl, package-repositories, and patchelf. Approved by two reviewers across 15 files (+206/-5 lines).
74%
#127 Fix spread tests imagecraft merged Merged after receiving approval from two reviewers and passing all CI checks. The changes fix spread tests across 11 files (+49/-38 lines).
74%
#1366 tests(spread): make release test less flaky charmcraft merged Merged changes that reduce flakiness in the spread release test, resolving issue #1362. Approved by two reviewers, the update modifies one file (+17/-7) after addressing feedback.
74%