← Back to issue list

projects: adoptable fields are optional if adopt-info used

View original Github issue

Metadata

Project
snapcraft
Number
#3693
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged into snapcraft/7.0. Allows project fields version, summary, description, and grade to be optional when adopt-info is used, with values adopted from metadata. Approved by reviewer, passed CI, and increased coverage by 0.24%.

Suggested action:

No scores available.

Issue body

Project fields `version`, `summary`, `description` and `grade` are allowed to be unspecified in project if `adopt-info` is used. The final values of such fields are still required and expected to be adopted from metadata, otherwise an error is raised. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? ----- CRAFT-1031

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into snapcraft/7.0. Allows project fields version, summary, description, and grade to be optional when adopt-info is used, with values adopted from metadata. Approved by reviewer, passed CI, and increased coverage by 0.24%.
qwen3.6-35b-a3b-mtp-q6 Merged. Permits version, summary, description, and grade fields to be omitted when adopt-info is used, with final values required to be adopted from metadata. Approved after reviewer feedback and integrated with improved test coverage.
qwen3.6-35b-a3b-mtp-q6 Merged into snapcraft/7.0. Updates project parsing to allow version, summary, description, and grade fields to remain optional when adopt-info is specified, with final values adopted from metadata. Approved after review.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#231 feat(app): add lists of adoptable and mandatory project fields craft-application merged Merged after three approvals and passing CI. Introduces adoptable and mandatory project field lists to application metadata for craftctl configuration. Resolved validation errors by rebasing and stacking on related PRs, maintaining full test coverage.
76%
#3700 meta: adopt metadata info snapcraft merged Merged into snapcraft/7.0 following reviewer approval and passing CI. Updates project fields with external metadata, addressing CRAFT-1036. The change modifies 21 files, increases coverage by 0.01%, and resolves the metadata adoption task.
76%
#217 feat: implement adoptable project variables craft-application merged Merged implementation of adoptable project variables, enabling metadata fields to be set via craftctl. Approved by two reviewers, passed CI, and includes integration tests. Changes span 17 files with 216 additions and 24 deletions.
71%