← Back to issue list

feat(app): add lists of adoptable and mandatory project fields

View original Github issue

Metadata

Project
craft-application
Number
#231
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

PR #231 (cmatsuoka) merged, adding project_variables and mandatory_adoptable_fields lists to AppMetadata for craftctl adoption of project fields. Restacked on merged #217 and #227; a7bb9839.

Resolution: closed resolved

Reason: The pull request was approved by 3 reviewers and merged into main (commit a7bb9839). AppMetadata.mandatory_adoptable_fields now exists in craft_application/application.py and is consumed by project/package services, with unit tests; it unblocked canonical/snapcraft#4601.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Project variables are defined in the application metadata and correspond to fields in the project model that can be set using craftctl. Mandatory adoptable fields are project fields that can be adopted from external sources, including craftctl and metadata files. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #231 (cmatsuoka) merged, adding project_variables and mandatory_adoptable_fields lists to AppMetadata for craftctl adoption of project fields. Restacked on merged #217 and #227; a7bb9839.
stealth/space-bunny-alpha — closed resolved Merged PR #231, adding adoptable and mandatory project-field lists to application metadata after stacking on merged PRs #217 and #227.
qwen/qwen3.6-35b-a3b — — Merged after three approvals and passing CI. Introduces adoptable and mandatory project field lists to application metadata for craftctl configuration. Resolved validation errors by rebasing and stacking on related PRs, maintaining full test coverage.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-application#217 (confidence 90%)

    PR #231 was restacked on the merged 'implement adoptable project variables' PR #217 (bd3ac7ed), which was reverted and reintroduced through #231

  • Related To: canonical/craft-application#227 (confidence 75%)

    Maintainer noted #231 was restacked on top of cherry-picked #217 and #227

  • Related To: canonical/snapcraft#4601 (confidence 70%)

    Maintainer stated this PR needed to land for snapcraft#4601 to land

Related issues

Issue Project State Summary Similarity
#3693 projects: adoptable fields are optional if adopt-info used snapcraft merged PR #3693 merged into snapcraft/7.0 (merge d9b4f700f, feature commit 0b05dbfc2) for CRAFT-1031, making version/summary/description/grade optional when adopt-info is set, with errors still raised if values are never adopted.
72%
#3700 meta: adopt metadata info snapcraft merged Merged PR #3700 via 6df548d3d, adopting external metadata for project fields and completing CRAFT-1036.
72%