← Back to issue list

utils: platform detection logic

View original Github issue

Metadata

Project
snapcraft
Number
#3698
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged into snapcraft/7.0 following reviewer approval and successful CI. The change imports platform detection logic from Charmcraft and refactors tests to use mocker. Two files modified, yielding a 1.16% test coverage increase.

Suggested action: —

No scores available.

Issue body

Imported from Charmcraft with tests updated to use mocker. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged into snapcraft/7.0 following reviewer approval and successful CI. The change imports platform detection logic from Charmcraft and refactors tests to use mocker. Two files modified, yielding a 1.16% test coverage increase.
qwen3.6-35b-a3b-mtp-q6 — — Merged into snapcraft/7.0. Imports platform detection logic from Charmcraft and updates tests to use mocker. Code coverage increased by 1.16 percent.
qwen3.6-35b-a3b-mtp-q6 — — Merged into snapcraft/7.0. Platform detection logic was imported from Charmcraft and tests updated to use mocker. Coverage increased by 1.16%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#11 fix: --platform no longer allowed in snapcraft starflow merged Merged a fix removing the unsupported --platform flag from snapcraft. Approved by one reviewer, the change updates one file with a net reduction of one line.
71%
#2657 test: Platform shorthand notation and charm plugin charmcraft merged Merged addition of tests for platform shorthand notation combined with the charm plugin, addressing regressions in earlier craft-platforms versions. Approved by two reviewers.
70%