← Back to issue list

meta: fix snap yaml generation to match legacy

View original Github issue

Metadata

Project
snapcraft
Number
#3721
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #3721 via e2bfca89d, aligning generated snap YAML with legacy by declaring the snap type and emitting an empty apps list when no apps exist.

Resolution: closed resolved

Reason: PR #3721 was approved and merged into snapcraft/7.0. Commit e2bfca89d fixed metadata generation for undeclared snap types and the no-app case; merge commit fd14dcee7 records the integration.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fix undeclared snap type and app list if no apps defined. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #3721 via e2bfca89d, aligning generated snap YAML with legacy by declaring the snap type and emitting an empty apps list when no apps exist.
stealth/space-bunny-alpha — closed resolved Merged #3721 via e2bfca89d, aligning generated snap YAML with legacy behavior by declaring the snap type and emitting an empty apps map when no apps are defined.
stealth/space-bunny-alpha — closed resolved Merged in #3721 via commit e2bfca89d, aligning snap YAML generation with legacy behavior by declaring the snap type and handling cases where no apps are defined.
qwen/qwen3.6-35b-a3b — — Merged into snapcraft/7.0. Fixed snap YAML generation to match legacy behavior by properly declaring snap type and handling empty app lists. Approved by maintainer, passed CI, and maintained full test coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into snapcraft/7.0. Fixed snap YAML generation to match legacy behavior by declaring snap type and app list when no apps are defined. Code achieved 100% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3959 meta: fix snap.yaml app slots snapcraft merged Merged snapcraft#3959 in commit 2d09913e7, adding missing app slot definitions to snap.yaml.
76%
#3637 meta: generate basic snap.yaml (CRAFT-801) snapcraft merged Merged #3637, adding minimal snap.yaml generation from existing project metadata to enable snap packing (0afa3dbfd; merge bc94255b4).
73%
#3734 meta: add layout to snap.yaml snapcraft merged Merged PR #3734 in commit b6df2713e (merge c5ebd810a), adding snap.yaml layout support, stricter project validation, and corrected environment field types.
70%
#4580 fix: do not propagate build-base to snap.yaml snapcraft merged Merged #4580 (d4e948f33), preventing build-base from being propagated into generated snap.yaml files.
70%