← Back to issue list

meta: fix snap yaml generation to match legacy

View original Github issue

Metadata

Project
snapcraft
Number
#3721
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged into snapcraft/7.0. Fixed snap YAML generation to match legacy behavior by properly declaring snap type and handling empty app lists. Approved by maintainer, passed CI, and maintained full test coverage.

Suggested action: —

No scores available.

Issue body

Fix undeclared snap type and app list if no apps defined. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged into snapcraft/7.0. Fixed snap YAML generation to match legacy behavior by properly declaring snap type and handling empty app lists. Approved by maintainer, passed CI, and maintained full test coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into snapcraft/7.0. Fixed snap YAML generation to match legacy behavior by declaring snap type and app list when no apps are defined. Code achieved 100% diff coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into snapcraft/7.0. Resolved undeclared snap type and empty app list issues in YAML generation to match legacy behavior. Codecov reported 100% diff coverage with no overall coverage change.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3637 meta: generate basic snap.yaml (CRAFT-801) snapcraft merged Merged into snapcraft/7.0, adding automatic generation of a basic snap.yaml to enable snap packing. Approved by a reviewer, passed CI, and increased test coverage by 1.16%.
78%
#3683 commands: add snap command snapcraft merged Merged into snapcraft/7.0. Implements legacy snap command support for package creation and fixes output parameter passing to managed instances. Approved by reviewer with passing CI checks.
74%
#3959 meta: fix snap.yaml app slots snapcraft merged Merged a pull request adding missing app slots to snap.yaml. Approved by a reviewer, passed CI checks, and successfully integrated into the repository.
72%