← Back to issue list

legacy command: remove close and release

View original Github issue

Metadata

Project
snapcraft
Number
#3726
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged into snapcraft/7.0 after approval and passing CI. The change removes legacy close and release commands, deleting 652 lines across 7 files and increasing test coverage by 0.48%.

Suggested action:

No scores available.

Issue body

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into snapcraft/7.0 after approval and passing CI. The change removes legacy close and release commands, deleting 652 lines across 7 files and increasing test coverage by 0.48%.
qwen3.6-35b-a3b-mtp-q6 Merged into snapcraft/7.0, removing the close and release methods from the legacy command. The change increased code coverage by 0.48 percent.
qwen3.6-35b-a3b-mtp-q6 Merged into snapcraft/7.0, removing close and release methods from the legacy command. The update increased unit test coverage by 0.48% and was approved by maintainer sergiusens.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3717 commands: release and close snapcraft merged Merged release and close command implementation. Approved by reviewer, passed CI checks, and modified 14 files with 459 additions and 661 deletions. Resolves CRAFT-981.
75%
#3609 tests: move legacy snapcraft tests (CRAFT-728) snapcraft merged Merged following reviewer approval and passing CI. Relocated unit tests for the renamed snapcraft_legacy package to tests/legacy, modifying 313 files (+579/-564 lines).
70%